Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutTableCell.cpp

Issue 2816983002: LayoutTableCell::OffsetFromContainer() should use the flipped offset of its parent. (Closed)
Patch Set: Reformat the test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/Element/getBoundingClientRect-vertical-child.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc.
8 * All rights reserved. 8 * All rights reserved.
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 383 matching lines...) Expand 10 before | Expand all | Expand 10 after
394 SetOverrideLogicalContentHeight( 394 SetOverrideLogicalContentHeight(
395 (row_height - CollapsedBorderAndCSSPaddingLogicalHeight()) 395 (row_height - CollapsedBorderAndCSSPaddingLogicalHeight())
396 .ClampNegativeToZero()); 396 .ClampNegativeToZero());
397 } 397 }
398 398
399 LayoutSize LayoutTableCell::OffsetFromContainer(const LayoutObject* o) const { 399 LayoutSize LayoutTableCell::OffsetFromContainer(const LayoutObject* o) const {
400 DCHECK_EQ(o, Container()); 400 DCHECK_EQ(o, Container());
401 401
402 LayoutSize offset = LayoutBlockFlow::OffsetFromContainer(o); 402 LayoutSize offset = LayoutBlockFlow::OffsetFromContainer(o);
403 if (Parent()) 403 if (Parent())
404 offset -= ParentBox()->LocationOffset(); 404 offset -= ParentBox()->PhysicalLocationOffset();
405 405
406 return offset; 406 return offset;
407 } 407 }
408 408
409 LayoutRect LayoutTableCell::LocalVisualRect() const { 409 LayoutRect LayoutTableCell::LocalVisualRect() const {
410 // If the table grid is dirty, we cannot get reliable information about 410 // If the table grid is dirty, we cannot get reliable information about
411 // adjoining cells, so we ignore outside borders. This should not be a problem 411 // adjoining cells, so we ignore outside borders. This should not be a problem
412 // because it means that the table is going to recalculate the grid, relayout 412 // because it means that the table is going to recalculate the grid, relayout
413 // and issue a paint invalidation of its current rect, which includes any 413 // and issue a paint invalidation of its current rect, which includes any
414 // outside borders of this cell. 414 // outside borders of this cell.
(...skipping 1067 matching lines...) Expand 10 before | Expand all | Expand 10 after
1482 } 1482 }
1483 1483
1484 bool LayoutTableCell::HasLineIfEmpty() const { 1484 bool LayoutTableCell::HasLineIfEmpty() const {
1485 if (GetNode() && HasEditableStyle(*GetNode())) 1485 if (GetNode() && HasEditableStyle(*GetNode()))
1486 return true; 1486 return true;
1487 1487
1488 return LayoutBlock::HasLineIfEmpty(); 1488 return LayoutBlock::HasLineIfEmpty();
1489 } 1489 }
1490 1490
1491 } // namespace blink 1491 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/Element/getBoundingClientRect-vertical-child.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698