third_party/WebKit/Source/core/frame/FrameView.cpp - Issue 2816953002: Shorten FrameSelection::IsAppearanceDirty() call stack

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2816953002: Shorten FrameSelection::IsAppearanceDirty() call stack (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/FrameView.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp

index 3a1de8192a5537cc6b7ed616211a494a7adcfa36..02ed411e409e6be5c19b09e51b87b278ed2ef324 100644

--- a/third_party/WebKit/Source/core/frame/FrameView.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp

@@ -3134,7 +3134,7 @@ void FrameView::UpdateLifecyclePhasesInternal(

composited_element_ids);

}

- DCHECK(!view.HasPendingSelection());

+ DCHECK(!frame_->Selection().IsLayoutSelectionNeedsUpdate());

DCHECK((frame_->GetDocument()->Printing() &&

Lifecycle().GetState() == DocumentLifecycle::kPrePaintClean) ||

Lifecycle().GetState() == DocumentLifecycle::kPaintClean);