third_party/WebKit/Source/core/editing/FrameSelection.h - Issue 2816953002: Shorten FrameSelection::IsAppearanceDirty() call stack

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelection.h

Issue 2816953002: Shorten FrameSelection::IsAppearanceDirty() call stack (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/FrameSelection.h

diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.h b/third_party/WebKit/Source/core/editing/FrameSelection.h

index 50a9e643c52b60fcf75b867d8bb4f138b34ccb3b..c5ece134428bb5d3e28f65779bfa724fdae8382c 100644

--- a/third_party/WebKit/Source/core/editing/FrameSelection.h

+++ b/third_party/WebKit/Source/core/editing/FrameSelection.h

@@ -183,7 +183,7 @@ class CORE_EXPORT FrameSelection final

void DocumentAttached(Document*);

void DidLayout();

- bool IsAppearanceDirty() const;

+ bool IsLayoutSelectionNeedsUpdate() const;

yosin_UTC9 2017/04/13 09:00:34 nit: s/IsLayoutSelectionNeedsUpdate()/NeedsLayoutS

yoichio 2017/04/13 09:24:10 Done.

void CommitAppearanceIfNeeded(LayoutView&);

void SetCaretVisible(bool caret_is_visible);

void ScheduleVisualUpdate() const;

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »