Add completion for do-stmt, refactor for reuse

Add completion for do-stmt, refactor for reuse

R=brianwilkerson@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/b9f9ad24f12858410b07d4e87c477a4717e14028

[messick, 2017-04-14 17:17:07]

messick@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[messick, 2017-04-14 17:17:07]

This stuff is hard to get right. Please let me know if there are any tools to
make tracking edit offsets easier.

[scheglov, 2017-04-14 17:33:39]

lgtm

https://codereview.chromium.org/2816943005/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart
(right):

https://codereview.chromium.org/2816943005/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart:258:
if (text.indexOf(new RegExp(r'do\s*;\s*while')) == 0) {
What if there is a comment in the text?

[messick, 2017-04-14 17:37:01]

https://codereview.chromium.org/2816943005/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart
(right):

https://codereview.chromium.org/2816943005/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart:258:
if (text.indexOf(new RegExp(r'do\s*;\s*while')) == 0) {
On 2017/04/14 17:33:39, scheglov wrote:
> What if there is a comment in the text?

Then this change is not applied. That's why I used the regexp. If someone has
typed a comment then we'll leave this section of the statement alone.

[Brian Wilkerson, 2017-04-17 16:34:02]

lgtm

[messick, 2017-04-17 17:56:37]

Description was changed from

==========
Add completion for do-stmt, refactor for reuse
==========

to

==========
Add completion for do-stmt, refactor for reuse

R=brianwilkerson@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b9f9ad24f12858410b07d4e87c477a4717e14028
==========

[messick, 2017-04-17 17:56:38]

Committed patchset #1 (id:1) manually as
b9f9ad24f12858410b07d4e87c477a4717e14028 (presubmit successful).