Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h

Issue 2816933003: Use Layout Opportunity Iterator to position new FC blocks. (Closed)
Patch Set: fix block-formatting-contexts-{005|007} Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h b/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h
index 269cba6d6f0ac6eb80dd0399f831b361c3578283..0924450906e1ad70f95eef3af7ecfab9a4c762cd 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h
@@ -38,9 +38,6 @@ class CORE_EXPORT NGFragmentBuilder final {
NGFragmentBuilder& AddChild(RefPtr<NGPhysicalFragment>,
const NGLogicalOffset&);
- NGFragmentBuilder& AddFloatingObject(RefPtr<NGFloatingObject>,
- const NGLogicalOffset&);
-
NGFragmentBuilder& SetBfcOffset(const NGLogicalOffset& offset);
NGFragmentBuilder& AddUnpositionedFloat(
@@ -114,6 +111,11 @@ class CORE_EXPORT NGFragmentBuilder final {
return unpositioned_floats_;
}
+ // Mutable list of positioned floats, i.e. floats with logical_offset set.
+ Vector<RefPtr<NGFloatingObject>>& MutablePositionedFloats() {
+ return positioned_floats_;
+ }
+
const WTF::Optional<NGLogicalOffset>& BfcOffset() const {
return bfc_offset_;
}
@@ -171,7 +173,6 @@ class CORE_EXPORT NGFragmentBuilder final {
// determine its block position in space.
Vector<RefPtr<NGFloatingObject>> unpositioned_floats_;
- Vector<NGLogicalOffset> floating_object_offsets_;
Vector<RefPtr<NGFloatingObject>> positioned_floats_;
WTF::Optional<NGLogicalOffset> bfc_offset_;

Powered by Google App Engine
This is Rietveld 408576698