Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Unified Diff: ui/native_theme/overlay_scrollbar_constants_aura.h

Issue 2816923002: change overlay scrollbar hover show to hover fade in (Closed)
Patch Set: merge FadeInDuration and FadeOutDuration to FadeDuration Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/gpu/render_widget_compositor.cc ('k') | ui/views/controls/scrollbar/overlay_scroll_bar.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/native_theme/overlay_scrollbar_constants_aura.h
diff --git a/ui/native_theme/overlay_scrollbar_constants_aura.h b/ui/native_theme/overlay_scrollbar_constants_aura.h
index a6192d902249f49721dd6162b35e642024bc9f1e..0ba92055378ce085dfa53e95f0ffd280c3177e85 100644
--- a/ui/native_theme/overlay_scrollbar_constants_aura.h
+++ b/ui/native_theme/overlay_scrollbar_constants_aura.h
@@ -20,11 +20,11 @@ constexpr float kOverlayScrollbarStrokeHoverAlpha = 0.5f;
// kOverlayScrollbarShowDelay is only for the case where the mouse hovers near
// the screen edge.
-constexpr base::TimeDelta kOverlayScrollbarShowDelay =
+constexpr base::TimeDelta kOverlayScrollbarFadeInDelay =
base::TimeDelta::FromMilliseconds(1000);
Evan Stade 2017/04/20 02:40:30 Any reason to keep the fadein/out separate?
chaopeng 2017/04/20 02:50:10 These two are different. FadeIn is by hovering a r
Evan Stade 2017/04/20 03:45:01 I would say we should use the same constant (and i
constexpr base::TimeDelta kOverlayScrollbarFadeOutDelay =
base::TimeDelta::FromMilliseconds(1000);
-constexpr base::TimeDelta kOverlayScrollbarFadeOutDuration =
+constexpr base::TimeDelta kOverlayScrollbarFadeDuration =
base::TimeDelta::FromMilliseconds(200);
// TODO(bokan): This is still undetermined. crbug.com/652520.
constexpr base::TimeDelta kOverlayScrollbarThinningDuration =
« no previous file with comments | « content/renderer/gpu/render_widget_compositor.cc ('k') | ui/views/controls/scrollbar/overlay_scroll_bar.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698