Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: components/browsing_data/core/browsing_data_utils.cc

Issue 2816723002: Add "Site Settings" option to Clear Browsing Data on Android (Closed)
Patch Set: fixes Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browsing_data/core/browsing_data_utils.cc
diff --git a/components/browsing_data/core/browsing_data_utils.cc b/components/browsing_data/core/browsing_data_utils.cc
index e3459aa5b93fa24c3272dab2b7760d6dc81f1f05..b54131a6aee6f30dc3797af01379b0265afc3eeb 100644
--- a/components/browsing_data/core/browsing_data_utils.cc
+++ b/components/browsing_data/core/browsing_data_utils.cc
@@ -90,6 +90,12 @@ base::string16 GetCounterTextFromResult(
static_cast<const BrowsingDataCounter::FinishedResult*>(result)
->Value();
text = l10n_util::GetPluralStringFUTF16(IDS_DEL_DOWNLOADS_COUNTER, count);
+ } else if (pref_name == prefs::kDeleteSiteSettings) {
+ BrowsingDataCounter::ResultInt count =
+ static_cast<const BrowsingDataCounter::FinishedResult*>(result)
+ ->Value();
+ text =
+ l10n_util::GetPluralStringFUTF16(IDS_DEL_SITE_SETTINGS_COUNTER, count);
} else if (pref_name == prefs::kDeleteBrowsingHistoryBasic) {
// The basic tab doesn't show history counter results.
NOTREACHED();
@@ -219,6 +225,9 @@ bool GetDeletionPreferenceFromDataType(
// Bookmarks are deleted on the Android side. No corresponding deletion
// preference.
return false;
+ case BrowsingDataType::SITE_SETTINGS:
+ *out_pref = prefs::kDeleteSiteSettings;
+ return true;
case BrowsingDataType::NUM_TYPES:
// This is not an actual type.
NOTREACHED();

Powered by Google App Engine
This is Rietveld 408576698