Add "Site Settings" option to Clear Browsing Data on Android

chrome/browser/content_settings/content_settings_pref_provider_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/content_settings/core/browser/content_settings_pref_provider.h"
 
 #include <memory>
 
 #include "base/auto_reset.h"
 #include "base/command_line.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/message_loop/message_loop.h"
-#include "base/test/test_timeouts.h"
-#include "base/threading/platform_thread.h"
+#include "base/test/simple_test_clock.h"
 #include "base/values.h"
 #include "chrome/browser/content_settings/content_settings_mock_observer.h"
 #include "chrome/browser/prefs/browser_prefs.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/content_settings/core/browser/content_settings_pref.h"
 #include "components/content_settings/core/browser/content_settings_registry.h"
 #include "components/content_settings/core/browser/content_settings_rule.h"
@@ skipping 587 matching lines @@
 TEST_F(PrefProviderTest, LastModified) {
   sync_preferences::TestingPrefServiceSyncable prefs;
   PrefProvider::RegisterProfilePrefs(prefs.registry());
 
   ContentSettingsPattern pattern_1 =
       ContentSettingsPattern::FromString("google.com");
   ContentSettingsPattern pattern_2 =
       ContentSettingsPattern::FromString("www.google.com");
   auto value = base::MakeUnique<base::Value>(CONTENT_SETTING_ALLOW);
 
-  base::Time t1 = base::Time::Now();
-
   // Create a  provider and set a few settings.
   PrefProvider provider(&prefs, false /* incognito */,
                         true /* store_last_modified */);
+  auto* clock = new base::SimpleTestClock();

[Bernhard Bauer, 2017/05/03 16:05:39]

Could you create this in a std::unique_ptr with base::MakeUnique, then get a raw
pointer out of it before passing it into the provider? At this point I'm
conditioned to dislike seeing raw "new" statements ;-) In other places too.

[dullweber, 2017/05/03 16:23:00]

Done.

+  clock->SetNow(base::Time::Now());
+  provider.SetClockForTesting(base::WrapUnique(clock));
+
+  base::Time t1 = clock->Now();
+
   provider.SetWebsiteSetting(pattern_1, ContentSettingsPattern::Wildcard(),
                              CONTENT_SETTINGS_TYPE_COOKIES, std::string(),
                              value->DeepCopy());
   provider.SetWebsiteSetting(pattern_2, ContentSettingsPattern::Wildcard(),
                              CONTENT_SETTINGS_TYPE_COOKIES, std::string(),
                              value->DeepCopy());
   // Make sure that the timestamps for pattern_1 and patter_2 are before |t2|.
-  base::PlatformThread::Sleep(TestTimeouts::tiny_timeout());
-  base::Time t2 = base::Time::Now();
+  clock->Advance(base::TimeDelta::FromSeconds(1));
+  base::Time t2 = clock->Now();
 
   base::Time last_modified = provider.GetWebsiteSettingLastModified(
       pattern_1, ContentSettingsPattern::Wildcard(),
       CONTENT_SETTINGS_TYPE_COOKIES, std::string());
-  EXPECT_GE(last_modified, t1);
-  EXPECT_LT(last_modified, t2);
+  EXPECT_EQ(last_modified, t1);
   last_modified = provider.GetWebsiteSettingLastModified(
       pattern_2, ContentSettingsPattern::Wildcard(),
       CONTENT_SETTINGS_TYPE_COOKIES, std::string());
-  EXPECT_GE(last_modified, t1);
-  EXPECT_LT(last_modified, t2);
+  EXPECT_EQ(last_modified, t1);
 
   // A change for pattern_1, which will update the last_modified timestamp.
   auto value2 = base::MakeUnique<base::Value>(CONTENT_SETTING_BLOCK);
   provider.SetWebsiteSetting(pattern_1, ContentSettingsPattern::Wildcard(),
                              CONTENT_SETTINGS_TYPE_COOKIES, std::string(),
                              value2->DeepCopy());
 
   last_modified = provider.GetWebsiteSettingLastModified(
       pattern_1, ContentSettingsPattern::Wildcard(),
       CONTENT_SETTINGS_TYPE_COOKIES, std::string());
-  EXPECT_GE(last_modified, t2);
+  EXPECT_EQ(last_modified, t2);
 
   // The timestamp of pattern_2 shouldn't change.
   last_modified = provider.GetWebsiteSettingLastModified(
       pattern_2, ContentSettingsPattern::Wildcard(),
       CONTENT_SETTINGS_TYPE_COOKIES, std::string());
-  EXPECT_GE(last_modified, t1);
-  EXPECT_LT(last_modified, t2);
+  EXPECT_EQ(last_modified, t1);
 
   provider.ShutdownOnUIThread();
 }
 
 }  // namespace content_settings