Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: src/arm/assembler-arm.h

Issue 2816703002: [arm] Remove embedded constant pool support. (Closed)
Patch Set: [arm] Remove embedded constant pool support. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/arm/assembler-arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/arm/assembler-arm.h
diff --git a/src/arm/assembler-arm.h b/src/arm/assembler-arm.h
index 076274d8bc12c2bda57d3ca41d09dbc4ffe290e0..5d32ac08a03f18614109d72ccea4dcd8beb908a0 100644
--- a/src/arm/assembler-arm.h
+++ b/src/arm/assembler-arm.h
@@ -142,7 +142,6 @@ struct Register {
};
// r7: context register
-// r8: constant pool pointer register if FLAG_enable_embedded_constant_pool.
// r9: lithium scratch
#define DECLARE_REGISTER(R) constexpr Register R = {Register::kCode_##R};
GENERAL_REGISTERS(DECLARE_REGISTER)
@@ -1558,12 +1557,6 @@ class Assembler : public AssemblerBase {
static int GetBranchOffset(Instr instr);
static bool IsLdrRegisterImmediate(Instr instr);
static bool IsVldrDRegisterImmediate(Instr instr);
- static Instr GetConsantPoolLoadPattern();
- static Instr GetConsantPoolLoadMask();
- static bool IsLdrPpRegOffset(Instr instr);
- static Instr GetLdrPpRegOffsetPattern();
- static bool IsLdrPpImmediateOffset(Instr instr);
- static bool IsVldrDPpImmediateOffset(Instr instr);
static int GetLdrRegisterImmediateOffset(Instr instr);
static int GetVldrDRegisterImmediateOffset(Instr instr);
static Instr SetLdrRegisterImmediateOffset(Instr instr, int offset);
@@ -1628,19 +1621,12 @@ class Assembler : public AssemblerBase {
}
}
- int EmitEmbeddedConstantPool() {
- DCHECK(FLAG_enable_embedded_constant_pool);
- return constant_pool_builder_.Emit(this);
- }
-
- bool ConstantPoolAccessIsInOverflow() const {
- return constant_pool_builder_.NextAccess(ConstantPoolEntry::INTPTR) ==
- ConstantPoolEntry::OVERFLOWED;
- }
-
void PatchConstantPoolAccessInstruction(int pc_offset, int offset,
ConstantPoolEntry::Access access,
- ConstantPoolEntry::Type type);
+ ConstantPoolEntry::Type type) {
+ // No embedded constant pool support.
+ UNREACHABLE();
+ }
protected:
// Relocation for a type-recording IC has the AST id added to it. This
@@ -1763,8 +1749,6 @@ class Assembler : public AssemblerBase {
int first_const_pool_32_use_;
int first_const_pool_64_use_;
- ConstantPoolBuilder constant_pool_builder_;
-
// The bound position, before this we cannot do instruction elimination.
int last_bound_pos_;
« no previous file with comments | « no previous file | src/arm/assembler-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698