Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3273)

Unified Diff: base/task_scheduler/task_tracker_posix.cc

Issue 2816653003: Do not take a MessageLoopForIO in the constructor of TaskTrackerPosix. (Closed)
Patch Set: self-review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/task_scheduler/task_tracker_posix.cc
diff --git a/base/task_scheduler/task_tracker_posix.cc b/base/task_scheduler/task_tracker_posix.cc
index 5c54f371949acf6100eda4f0d8a301057402d4e5..91fdec817a5d4e7463f05da2234a446a53636a9c 100644
--- a/base/task_scheduler/task_tracker_posix.cc
+++ b/base/task_scheduler/task_tracker_posix.cc
@@ -12,15 +12,17 @@
namespace base {
namespace internal {
-TaskTrackerPosix::TaskTrackerPosix(
- MessageLoopForIO* watch_file_descriptor_message_loop)
- : watch_file_descriptor_message_loop_(watch_file_descriptor_message_loop) {
- DCHECK(watch_file_descriptor_message_loop_);
-}
-
+TaskTrackerPosix::TaskTrackerPosix() = default;
TaskTrackerPosix::~TaskTrackerPosix() = default;
+void TaskTrackerPosix::Start(
+ MessageLoopForIO* watch_file_descriptor_message_loop) {
+ DCHECK(watch_file_descriptor_message_loop);
+ watch_file_descriptor_message_loop_ = watch_file_descriptor_message_loop_;
+}
+
void TaskTrackerPosix::PerformRunTask(std::unique_ptr<Task> task) {
+ DCHECK(watch_file_descriptor_message_loop_);
FileDescriptorWatcher file_descriptor_watcher(
watch_file_descriptor_message_loop_);
TaskTracker::PerformRunTask(std::move(task));
« base/task_scheduler/task_tracker_posix.h ('K') | « base/task_scheduler/task_tracker_posix.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698