Issue 2816633003: Reapply "Gracefully handle if loaded dill program has no mainMethod set."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2816633003: Reapply "Gracefully handle if loaded dill program has no mainMethod set." (Closed)

Created:
3 years, 8 months ago by Emily Fortuna

Modified:
3 years, 8 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Reapply "Gracefully handle if loaded dill program has no mainMethod set." The previous (identical) version of this CL was reverted due to a spurious unrelated error on the dart-flutter integration bots. BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/fe3a583223a2be066d88f7619743cc2e4e12cb16

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
	M	pkg/compiler/lib/src/library_loader.dart	View		1 chunk	+6 lines, -5 lines	0 comments	Download

Total messages: 5 (2 generated)

Emily Fortuna

this is the same as https://chromiumcodereview.appspot.com/2800463002/

3 years, 8 months ago (2017-04-11 21:41:34 UTC) #2

Emily Fortuna

3 years, 8 months ago (2017-04-11 23:30:16 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
fe3a583223a2be066d88f7619743cc2e4e12cb16 (presubmit successful).