Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2088)

Unified Diff: content/renderer/render_frame_impl.h

Issue 281663002: Create RenderFrameProxyHost at time of swap-out instead of commit. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ready for review Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.h
diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h
index af42b7bc86e5d1619ec33a97ba657ead9de8506d..d029945682dc9114e8db769de56983f6386ad18d 100644
--- a/content/renderer/render_frame_impl.h
+++ b/content/renderer/render_frame_impl.h
@@ -18,6 +18,7 @@
#include "content/public/common/referrer.h"
#include "content/public/renderer/render_frame.h"
#include "content/renderer/media/webmediaplayer_delegate.h"
+#include "content/renderer/render_frame_proxy.h"
#include "content/renderer/renderer_webcookiejar_impl.h"
#include "ipc/ipc_message.h"
#include "third_party/WebKit/public/web/WebDataSource.h"
@@ -74,6 +75,9 @@ class CONTENT_EXPORT RenderFrameImpl
// TODO(creis): We should structure this so that |SetWebFrame| isn't needed.
static RenderFrameImpl* Create(RenderViewImpl* render_view, int32 routing_id);
+ // Returns the RenderFrameImpl for the given routing ID.
+ static RenderFrameImpl* FromRoutingID(int routing_id);
+
// Just like RenderFrame::FromWebFrame but returns the implementation.
static RenderFrameImpl* FromWebFrame(blink::WebFrame* web_frame);
@@ -88,6 +92,12 @@ class CONTENT_EXPORT RenderFrameImpl
return is_swapped_out_;
}
+ // TODO(nasko): Remove this method once RenderFrame no longer uses swapped out
+ // state.
+ void set_render_frame_proxy(RenderFrameProxy* proxy) {
+ render_frame_proxy_ = proxy;
+ }
+
// Out-of-process child frames receive a signal from RenderWidgetCompositor
// when a compositor frame has committed.
void DidCommitCompositorFrame();
@@ -412,7 +422,7 @@ class CONTENT_EXPORT RenderFrameImpl
// The documentation for these functions should be in
// content/common/*_messages.h for the message that the function is handling.
void OnBeforeUnload();
- void OnSwapOut();
+ void OnSwapOut(int proxy_routing_id);
void OnChildFrameProcessGone();
void OnBuffersSwapped(const FrameMsg_BuffersSwapped_Params& params);
void OnCompositorFrameSwapped(const IPC::Message& message);
@@ -520,6 +530,7 @@ class CONTENT_EXPORT RenderFrameImpl
blink::WebLocalFrame* frame_;
base::WeakPtr<RenderViewImpl> render_view_;
+ RenderFrameProxy* render_frame_proxy_;
Charlie Reis 2014/05/15 00:32:50 This should have a comment saying it's usually nul
nasko 2014/05/15 18:47:13 Done.
int routing_id_;
bool is_swapped_out_;
bool is_detaching_;

Powered by Google App Engine
This is Rietveld 408576698