content/browser/frame_host/render_frame_host_manager_unittest.cc - Issue 281663002: Create RenderFrameProxyHost at time of swap-out instead of commit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_manager_unittest.cc

Issue 281663002: Create RenderFrameProxyHost at time of swap-out instead of commit. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix IPC_BEGIN_MESSAGE_MAP macro, as _EX version doesn't exist anymore. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/render_frame_host_manager_unittest.cc

diff --git a/content/browser/frame_host/render_frame_host_manager_unittest.cc b/content/browser/frame_host/render_frame_host_manager_unittest.cc

index 9bd4e64263cc528f14417da2acb5a32324f41e15..798ab6a4ecf9b918db0c00b4b1da49195e966022 100644

--- a/content/browser/frame_host/render_frame_host_manager_unittest.cc

+++ b/content/browser/frame_host/render_frame_host_manager_unittest.cc

@@ -1048,7 +1048,8 @@ TEST_F(RenderFrameHostManagerTest, WebUIInNewTab) {

RenderFrameHostManager* manager1 =

web_contents1->GetRenderManagerForTesting();

// Test the case that new RVH is considered live.

- manager1->current_host()->CreateRenderView(base::string16(), -1, -1, false);

+ manager1->current_host()->CreateRenderView(

+ base::string16(), -1, MSG_ROUTING_NONE, -1, false);

// Navigate to a WebUI page.

const GURL kUrl1("chrome://foo");

@@ -1079,7 +1080,8 @@ TEST_F(RenderFrameHostManagerTest, WebUIInNewTab) {

web_contents2->GetRenderManagerForTesting();

// Make sure the new RVH is considered live. This is usually done in

// RenderWidgetHost::Init when opening a new tab from a link.

- manager2->current_host()->CreateRenderView(base::string16(), -1, -1, false);

+ manager2->current_host()->CreateRenderView(

+ base::string16(), -1, MSG_ROUTING_NONE, -1, false);

const GURL kUrl2("chrome://foo/bar");

NavigationEntryImpl entry2(NULL /* instance */, -1 /* page_id */, kUrl2,

@@ -1282,7 +1284,7 @@ TEST_F(RenderFrameHostManagerTest, CleanUpSwappedOutRVHOnProcessCrash) {

// Make sure the new opener RVH is considered live.

opener1_manager->current_host()->CreateRenderView(

- base::string16(), -1, -1, false);

+ base::string16(), -1, MSG_ROUTING_NONE, -1, false);

// Use a cross-process navigation in the opener to swap out the old RVH.

EXPECT_FALSE(opener1_manager->GetSwappedOutRenderViewHost(