Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1140)

Unified Diff: content/browser/frame_host/render_frame_host_manager.h

Issue 281663002: Create RenderFrameProxyHost at time of swap-out instead of commit. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix IPC_BEGIN_MESSAGE_MAP macro, as _EX version doesn't exist anymore. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_manager.h
diff --git a/content/browser/frame_host/render_frame_host_manager.h b/content/browser/frame_host/render_frame_host_manager.h
index 598dbd415f159650f479814b86f0e15640a34440..dce2dbb2e01b3e9753edb6f8c3d53da8487be9fb 100644
--- a/content/browser/frame_host/render_frame_host_manager.h
+++ b/content/browser/frame_host/render_frame_host_manager.h
@@ -58,12 +58,10 @@ class CONTENT_EXPORT RenderFrameHostManager : public NotificationObserver {
// process is not shared, then the WebContentsImpl will act as though the
// renderer is not running (i.e., it will render "sad tab"). This method is
// automatically called from LoadURL.
- //
- // If you are attaching to an already-existing RenderView, you should call
- // InitWithExistingID.
virtual bool CreateRenderViewForRenderManager(
RenderViewHost* render_view_host,
int opener_route_id,
+ int proxy_routing_id,
CrossProcessFrameConnector* cross_process_frame_connector) = 0;
virtual void BeforeUnloadFiredFromRenderManager(
bool proceed, const base::TimeTicks& proceed_time,
@@ -373,11 +371,15 @@ class CONTENT_EXPORT RenderFrameHostManager : public NotificationObserver {
bool hidden);
// Sets up the necessary state for a new RenderViewHost with the given opener,
- // if necessary. Returns early if the RenderViewHost has already been
+ // if necessary. It creates a RenderFrameProxy in the target renderer process
+ // with the given |proxy_routing_id|, which is used to route IPC messages when
+ // in swapped out state. Returns early if the RenderViewHost has already been
// initialized for another RenderFrameHost.
// TODO(creis): opener_route_id is currently for the RenderViewHost but should
// be for the RenderFrame, since frames can have openers.
- bool InitRenderView(RenderViewHost* render_view_host, int opener_route_id);
+ bool InitRenderView(RenderViewHost* render_view_host,
+ int opener_route_id,
+ int proxy_routing_id);
// Sets the pending RenderFrameHost/WebUI to be the active one. Note that this
// doesn't require the pending render_frame_host_ pointer to be non-NULL,
« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.cc ('k') | content/browser/frame_host/render_frame_host_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698