Create RenderFrameProxyHost at time of swap-out instead of commit.

content/browser/renderer_host/render_view_host_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 215 matching lines @@
   // Set up the RenderView child process. Virtual because it is overridden by
   // TestRenderViewHost. If the |frame_name| parameter is non-empty, it is used
   // as the name of the new top-level frame.
   // The |opener_route_id| parameter indicates which RenderView created this
   // (MSG_ROUTING_NONE if none). If |max_page_id| is larger than -1, the
   // RenderView is told to start issuing page IDs at |max_page_id| + 1.
   // |window_was_created_with_opener| is true if this top-level frame was
   // created with an opener. (The opener may have been closed since.)
   virtual bool CreateRenderView(const base::string16& frame_name,
                                 int opener_route_id,
+                                int proxy_routing_id,

[Charlie Reis, 2014/05/15 00:32:50]

This feels strange to me.  A RenderFrameProxy is frame-specific, unlike
RenderView, and most RenderViews won't have them.  Is there another way to
handle this?  (We should at least have a comment about this similar to the one
in view_messages.h, but it would be nice to avoid passing it here if possible.)

minor nit: It looks a little strange to have route vs routing in the two
parameter names.

[nasko, 2014/05/15 18:47:13]

As discussed, there isn't any other way that will be much cleaner, so leaving it
in place. I've moved the proxy routing id to be next to swapped out state
wherever it is encountered and fixed the route vs routing here.

                                 int32 max_page_id,
                                 bool window_was_created_with_opener);
 
   base::TerminationStatus render_view_termination_status() const {
     return render_view_termination_status_;
   }
 
   // Returns the content specific prefs for this RenderViewHost.
   WebPreferences GetWebkitPrefs(const GURL& url);
 
@@ skipping 399 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(RenderViewHostImpl);
 };
 
 #if defined(COMPILER_MSVC)
 #pragma warning(pop)
 #endif
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_