Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Side by Side Diff: content/renderer/render_frame_proxy.cc

Issue 281663002: Create RenderFrameProxyHost at time of swap-out instead of commit. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: s/render_view_host/GetRenderViewHost/ Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "content/renderer/render_frame_proxy.h"
6
7 #include <map>
8
9 #include "base/lazy_instance.h"
10 #include "content/common/frame_messages.h"
11 #include "content/common/swapped_out_messages.h"
12 #include "content/renderer/render_frame_impl.h"
13 #include "content/renderer/render_thread_impl.h"
14 #include "content/renderer/render_view_impl.h"
15
16 namespace content {
17
18 namespace {
19
20 typedef std::map<int, RenderFrameProxy*> RoutingIDProxyMap;
21 static base::LazyInstance<RoutingIDProxyMap> g_routing_id_proxy_map =
22 LAZY_INSTANCE_INITIALIZER;
23
24 } // namespace
25
26 // static
27 RenderFrameProxy* RenderFrameProxy::CreateFrameProxy(int routing_id,
28 int frame_routing_id) {
29 DCHECK_NE(routing_id, MSG_ROUTING_NONE);
30 RenderFrameProxy* proxy = new RenderFrameProxy(routing_id, frame_routing_id);
31 return proxy;
32 }
33
34 // static
35 RenderFrameProxy* RenderFrameProxy::FromRoutingID(int32 routing_id) {
36 RoutingIDProxyMap* proxies = g_routing_id_proxy_map.Pointer();
37 RoutingIDProxyMap::iterator it = proxies->find(routing_id);
38 return it == proxies->end() ? NULL : it->second;
39 }
40
41 RenderFrameProxy::RenderFrameProxy(int routing_id, int frame_routing_id)
42 : routing_id_(routing_id),
43 frame_routing_id_(frame_routing_id) {
44 std::pair<RoutingIDProxyMap::iterator, bool> result =
45 g_routing_id_proxy_map.Get().insert(std::make_pair(routing_id_, this));
46 CHECK(result.second) << "Inserting a duplicate item.";
47 RenderThread::Get()->AddRoute(routing_id_, this);
48
49 render_frame_ = RenderFrameImpl::FromRoutingID(frame_routing_id);
50 CHECK(render_frame_);
51 }
52
53 RenderFrameProxy::~RenderFrameProxy() {
54 RenderThread::Get()->RemoveRoute(routing_id_);
55 g_routing_id_proxy_map.Get().erase(routing_id_);
56 }
57
58 bool RenderFrameProxy::OnMessageReceived(const IPC::Message& msg) {
59 bool handled = true;
60 bool msg_is_ok = true;
61 IPC_BEGIN_MESSAGE_MAP_EX(RenderFrameProxy, msg, msg_is_ok)
62 IPC_MESSAGE_HANDLER(FrameMsg_DeleteProxy, OnDeleteProxy)
63 IPC_MESSAGE_UNHANDLED(handled = false)
64 IPC_END_MESSAGE_MAP_EX()
65
66 if (!handled)
67 return render_frame_->OnMessageReceived(msg);
68
69 if (!msg_is_ok) {
70 // The message had a handler, but its deserialization failed.
71 // Kill the renderer to avoid potential spoofing attacks.
72 int id = msg.type();
73 CHECK(false) << "Unable to deserialize " << id << " in RenderFrameProxy.";
74 }
75
76 return handled;
77 }
78
79 bool RenderFrameProxy::Send(IPC::Message* message) {
80 if (!SwappedOutMessages::CanSendWhileSwappedOut(message)) {
81 delete message;
82 return false;
83 }
84 message->set_routing_id(routing_id_);
85 return RenderThread::Get()->Send(message);
86 }
87
88 void RenderFrameProxy::OnDeleteProxy() {
89 RenderFrameImpl* render_frame =
90 RenderFrameImpl::FromRoutingID(frame_routing_id_);
91 CHECK(render_frame);
92 render_frame->set_render_frame_proxy(NULL);
93
94 delete this;
95 }
96
97 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698