Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1477)

Unified Diff: content/browser/renderer_host/input/passthrough_touch_event_queue.h

Issue 2816613003: Add suppresion of slop region touches in browser (Closed)
Patch Set: Fix the tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/input/passthrough_touch_event_queue.h
diff --git a/content/browser/renderer_host/input/passthrough_touch_event_queue.h b/content/browser/renderer_host/input/passthrough_touch_event_queue.h
index 598e9b86632fd56fb5fe4f2764df083a0f86e5de..6e18504fcb875dfaa74542e439f45d7583c8116d 100644
--- a/content/browser/renderer_host/input/passthrough_touch_event_queue.h
+++ b/content/browser/renderer_host/input/passthrough_touch_event_queue.h
@@ -12,6 +12,7 @@
namespace content {
class TouchTimeoutHandler;
+class TouchMoveSlopSuppressor;
// A queue that processes a touch-event and forwards it on to the
// renderer process immediately. This class assumes that queueing will
@@ -115,6 +116,10 @@ class CONTENT_EXPORT PassthroughTouchEventQueue : public TouchEventQueue {
// cancelled after a touch timeout.
bool drop_remaining_touches_in_sequence_;
+ // Suppression of TouchMove's within a slop region when a sequence has not yet
tdresser 2017/04/13 18:13:35 Suppression of -> Suppresses
Navid Zolghadr 2017/04/18 14:47:41 Done.
+ // been preventDefaulted.
+ std::unique_ptr<TouchMoveSlopSuppressor> touchmove_slop_suppressor_;
tdresser 2017/04/13 18:13:35 Why use a unique_ptr here, instead of just stack a
Navid Zolghadr 2017/04/18 14:47:41 If I don't use pointers here I need to put the ful
tdresser 2017/04/18 15:20:26 Acknowledged.
+
// Optional handler for timed-out touch event acks.
std::unique_ptr<TouchTimeoutHandler> timeout_handler_;

Powered by Google App Engine
This is Rietveld 408576698