Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Unified Diff: components/payments/content/android/payment_manifest_parser_android.cc

Issue 2816573002: Fix payments where logic was in DCHECK. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/payments/content/android/payment_manifest_parser_android.cc
diff --git a/components/payments/content/android/payment_manifest_parser_android.cc b/components/payments/content/android/payment_manifest_parser_android.cc
index f32abb67cf5a5fbb60783bf10140a6fdaf62d4d5..b8287fea9f9f827fe984f33c84017bba778fd157 100644
--- a/components/payments/content/android/payment_manifest_parser_android.cc
+++ b/components/payments/content/android/payment_manifest_parser_android.cc
@@ -41,10 +41,11 @@ class ParseCallback {
env, web_app_manifest_urls.size());
for (size_t i = 0; i < web_app_manifest_urls.size(); ++i) {
- DCHECK(Java_PaymentManifestParser_addUri(
+ bool valid_uri = Java_PaymentManifestParser_addUri(
env, juris.obj(), base::checked_cast<int>(i),
base::android::ConvertUTF8ToJavaString(
- env, web_app_manifest_urls[i].spec())));
+ env, web_app_manifest_urls[i].spec()));
+ DCHECK(valid_uri);
}
// Can trigger synchronous deletion of PaymentManifestParserAndroid.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698