Login screen IME policy does not apply in user session

chrome/browser/chromeos/login/login_screen_policy_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/memory/ref_counted.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "chrome/browser/browser_process.h"
+#include "chrome/browser/chromeos/login/login_wizard.h"
 #include "chrome/browser/chromeos/login/startup_utils.h"
+#include "chrome/browser/chromeos/login/test/oobe_screen_waiter.h"
+#include "chrome/browser/chromeos/login/ui/login_display_host.h"
 #include "chrome/browser/chromeos/policy/device_policy_cros_browser_test.h"
 #include "chrome/browser/chromeos/policy/proto/chrome_device_policy.pb.h"
 #include "chrome/browser/chromeos/settings/cros_settings.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
 #include "chrome/grit/generated_resources.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "chromeos/chromeos_switches.h"
 #include "chromeos/settings/cros_settings_names.h"
+#include "components/prefs/pref_service.h"
+#include "components/prefs/scoped_user_pref_update.h"
 #include "components/user_manager/user_manager.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/ime/chromeos/input_method_manager.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 
 namespace em = enterprise_management;
 
+namespace {
+const char kTestUser[] = "test-user@example.com";
+}  // namespace
+
 namespace chromeos {
 
 class LoginScreenPolicyTest : public policy::DevicePolicyCrosBrowserTest {
  public:
   void RefreshDevicePolicyAndWaitForSettingChange(
       const char* cros_setting_name);
 
  protected:
-  void SetUpCommandLine(base::CommandLine* command_line) override {
-    command_line->AppendSwitch(switches::kLoginManager);
-    command_line->AppendSwitch(switches::kForceLoginManagerInTests);

[xiyuan, 2017/04/12 19:33:44]

This would make the browser test to run in a stub user session. Calling
ShowLoginWizard later is not a well tested code path.

The failure is because switches::kLoginManager would cause login screen to be
created and ShowLoginWizard attempts to create it again. Think we should be just
remove ShowLoginWizard.

If OobeScreenWaiter does not work, we can use

  content::WindowedNotificationObserver(
      chrome::NOTIFICATION_LOGIN_OR_LOCK_WEBUI_VISIBLE,
      content::NotificationService::AllSources()).Wait();

, that are used by a few login related browser tests.

[pmarko, 2017/04/12 20:29:32]

Done.

-  }
-
   void SetUpInProcessBrowserTestFixture() override {
     InstallOwnerKey();
     MarkAsEnterpriseOwned();
     DevicePolicyCrosBrowserTest::SetUpInProcessBrowserTestFixture();
   }
 
   void TearDownOnMainThread() override {
     // This shuts down the login UI.
     base::ThreadTaskRunnerHandle::Get()->PostTask(
         FROM_HERE, base::Bind(&chrome::AttemptExit));
     base::RunLoop().RunUntilIdle();
   }
+
+  void RegisterUser(const std::string& user_id) {
+    ListPrefUpdate users_pref(g_browser_process->local_state(),
+                              "LoggedInUsers");
+    users_pref->AppendIfNotPresent(base::MakeUnique<base::Value>(user_id));
+  }
 };
 
 void LoginScreenPolicyTest::RefreshDevicePolicyAndWaitForSettingChange(
     const char* cros_setting_name) {
   scoped_refptr<content::MessageLoopRunner> runner(
       new content::MessageLoopRunner);
   std::unique_ptr<CrosSettings::ObserverSubscription> subscription(
       chromeos::CrosSettings::Get()->AddSettingsObserver(
           cros_setting_name, runner->QuitClosure()));
 
   RefreshDevicePolicy();
   runner->Run();
 }
 
 IN_PROC_BROWSER_TEST_F(LoginScreenPolicyTest, DisableSupervisedUsers) {
   EXPECT_FALSE(user_manager::UserManager::Get()->AreSupervisedUsersAllowed());
 
   em::ChromeDeviceSettingsProto& proto(device_policy()->payload());
   proto.mutable_supervised_users_settings()->set_supervised_users_enabled(true);
   RefreshDevicePolicyAndWaitForSettingChange(
       chromeos::kAccountsPrefSupervisedUsersEnabled);
 
   EXPECT_TRUE(user_manager::UserManager::Get()->AreSupervisedUsersAllowed());
 }
 
+IN_PROC_BROWSER_TEST_F(LoginScreenPolicyTest, PRE_RestrictInputMethods) {
+  RegisterUser(kTestUser);
+  StartupUtils::MarkOobeCompleted();
+}
+
 IN_PROC_BROWSER_TEST_F(LoginScreenPolicyTest, RestrictInputMethods) {
+  ShowLoginWizard(OobeScreen::SCREEN_SPECIAL_LOGIN);
+  OobeScreenWaiter(OobeScreen::SCREEN_ACCOUNT_PICKER).Wait();
+
   input_method::InputMethodManager* imm =
       input_method::InputMethodManager::Get();
   ASSERT_TRUE(imm);
 
   ASSERT_EQ(0U, imm->GetActiveIMEState()->GetAllowedInputMethods().size());
 
   em::ChromeDeviceSettingsProto& proto(device_policy()->payload());
   proto.mutable_login_screen_input_methods()->add_login_screen_input_methods(
       "xkb:de::ger");
   RefreshDevicePolicyAndWaitForSettingChange(
       chromeos::kDeviceLoginScreenInputMethods);
 
   ASSERT_EQ(1U, imm->GetActiveIMEState()->GetAllowedInputMethods().size());
 
   // Remove the policy again
   proto.mutable_login_screen_input_methods()
       ->clear_login_screen_input_methods();
   RefreshDevicePolicyAndWaitForSettingChange(
       chromeos::kDeviceLoginScreenInputMethods);
 
   ASSERT_EQ(0U, imm->GetActiveIMEState()->GetAllowedInputMethods().size());
+
+  base::ThreadTaskRunnerHandle::Get()->DeleteSoon(
+      FROM_HERE, LoginDisplayHost::default_host());

[xiyuan, 2017/04/12 19:33:44]

Think this is not necessary.

[pmarko, 2017/04/12 20:29:32]

Done.

 }
 
 class LoginScreenLocalePolicyTest : public LoginScreenPolicyTest {
  protected:
   LoginScreenLocalePolicyTest() {}
 
   void SetUpInProcessBrowserTestFixture() override {
     LoginScreenPolicyTest::SetUpInProcessBrowserTestFixture();
 
     em::ChromeDeviceSettingsProto& proto(device_policy()->payload());
@@ skipping 17 matching lines @@
   // Make sure this is really French and differs from the English title.
   std::string loaded =
       ui::ResourceBundle::GetSharedInstance().ReloadLocaleResources("en-US");
   EXPECT_EQ("en-US", loaded);
   base::string16 english_title =
       l10n_util::GetStringUTF16(IDS_LOGIN_POD_SIGNING_IN);
   EXPECT_NE(french_title, english_title);
 }
 
 }  // namespace chromeos