Index: content/browser/resources/media/dump_creator.js |
diff --git a/content/browser/resources/media/dump_creator.js b/content/browser/resources/media/dump_creator.js |
index 90de1d5d6f2ea76bdaf7950ee52745f47f5c0dad..097a0a9386bb3a43b1a91236b181a32f984a04d8 100644 |
--- a/content/browser/resources/media/dump_creator.js |
+++ b/content/browser/resources/media/dump_creator.js |
@@ -34,26 +34,30 @@ var DumpCreator = (function() { |
'<p><label><input type=checkbox>' + |
'Enable diagnostic audio recordings</label></p>' + |
'<p class=audio-diagnostic-dumps-info>A diagnostic audio recording is' + |
- ' used for analyzing audio problems. It consists of two files and' + |
- ' contains the audio played out from the speaker and recorded from' + |
+ ' used for analyzing audio problems. It consists of several files and' + |
+ ' contains the audio played out to the speaker and recorded from' + |
tommi (sloooow) - chröme
2017/05/03 09:12:12
nit: could replace the last 'and' with a comma.
Henrik Grunell
2017/05/12 12:20:18
Hmm, that seems awkward too. Changed the "saved to
|
' the microphone and is saved to the local disk. Checking this box' + |
- ' will enable the recording for ongoing WebRTC calls and for future' + |
- ' WebRTC calls. When the box is unchecked or this page is closed, all' + |
- ' ongoing recordings will be stopped and this recording' + |
- ' functionality will be disabled for future WebRTC calls. Recordings' + |
- ' in multiple tabs are supported as well as multiple recordings in' + |
- ' the same tab. When enabling, you select a base filename to which' + |
- ' suffixes will be appended as</p>' + |
+ ' will enable the recording for ongoing WebRTC calls, all ongoing' + |
tommi (sloooow) - chröme
2017/05/03 09:12:12
"recording of ongoing"
Henrik Grunell
2017/05/12 12:20:18
Done.
|
+ ' playout streams (also non-WebRTC), all ongoing recording streams' + |
tommi (sloooow) - chröme
2017/05/03 09:12:11
"(including non-WebRTC)"
It's not clear to me wha
Henrik Grunell
2017/05/12 12:20:17
Done.
|
+ ' (also non-WebRTC) and for future WebRTC calls and streams. When the' + |
tommi (sloooow) - chröme
2017/05/03 09:12:12
nit: you could replace "calls and" with "audio" ->
Henrik Grunell
2017/05/12 12:20:18
WebRTC call would refer to the AEC dump, which is
|
+ ' box is unchecked or this page is closed, all ongoing recordings' + |
tommi (sloooow) - chröme
2017/05/03 09:12:11
'this page is closed' Does that stop an ongoing r
Henrik Grunell
2017/05/12 12:20:17
Yes, it's (still) true. I verified just now.
|
+ ' will be stopped and this recording functionality will be disabled' + |
tommi (sloooow) - chröme
2017/05/03 09:12:12
nit: "the recording functionality disabled"
Henrik Grunell
2017/05/12 12:20:17
Done.
|
+ ' for future WebRTC calls and streams. Recordings in multiple tabs' + |
tommi (sloooow) - chröme
2017/05/03 09:12:11
I'd skip "fore future WebRTC calls and streams" si
tommi (sloooow) - chröme
2017/05/03 09:12:12
"Recordings in multiple tabs" doesn't sound right.
Henrik Grunell
2017/05/12 12:20:17
Done.
Henrik Grunell
2017/05/12 12:20:18
Sounds good. Done.
|
+ ' are supported as well as multiple recordings in the same tab. When' + |
tommi (sloooow) - chröme
2017/05/03 09:12:11
"from the same tab"
Henrik Grunell
2017/05/12 12:20:17
Done.
|
+ ' enabling, you select a base filename to which suffixes will be' + |
tommi (sloooow) - chröme
2017/05/03 09:12:11
remove "you "
Also suggest: "to which the followin
Henrik Grunell
2017/05/12 12:20:17
Good suggestions. Done.
|
+ ' appended as</p>' + |
'<p><div><base filename>.<render process ID>' + |
- '.aec_dump.<recording ID></div>' + |
+ '.aec_dump.<AEC dump recording ID></div>' + |
'<div><base filename>.<render process ID>' + |
- '.source_input.<stream ID>.wav</div></p>' + |
+ '.source_input.<stream ID>.wav</div>' + |
+ '<div><base filename>.output' + |
+ '.<output stream recording ID>.wav</div></p>' + |
'<p class=audio-diagnostic-dumps-info>If recordings are disabled and' + |
tommi (sloooow) - chröme
2017/05/03 09:12:11
'recordings are disabled' also doesn't sound right
Henrik Grunell
2017/05/12 12:20:17
Good point. Also agree it would be good having a n
|
' then enabled using the same base filename, the microphone recording' + |
tommi (sloooow) - chröme
2017/05/03 09:12:12
re-enabled
Henrik Grunell
2017/05/12 12:20:18
Done.
|
- ' file will be overwritten, and the AEC dump file will be appended to' + |
- ' and may become invalid. It is recommended to choose a new base' + |
- ' filename each time or move the produced files before enabling' + |
- ' again.</p>' + |
+ ' files ("source_input") will be overwritten, and the AEC' + |
tommi (sloooow) - chröme
2017/05/03 09:12:12
instead of "the microphone recording files", I'd j
Henrik Grunell
2017/05/12 12:20:17
Done.
|
+ ' dump file will be appended to and may become invalid. It is' + |
tommi (sloooow) - chröme
2017/05/03 09:12:12
this isn't really clear. "and the AEC dump file w
Henrik Grunell
2017/05/12 12:20:17
Appending to the previous file. Changed wording.
|
+ ' recommended to choose a new base filename each time or move the' + |
tommi (sloooow) - chröme
2017/05/03 09:12:11
Perhaps it might be best to simply say something l
Henrik Grunell
2017/05/12 12:20:17
Yes, I think that's a good idea. Done.
|
+ ' produced files before enabling again.</p>' + |
'<p><label><input type=checkbox>' + |
'Enable diagnostic packet and event recording</label></p>' + |
'<p class=audio-diagnostic-dumps-info>A diagnostic packet and event' + |