Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Side by Side Diff: content/browser/resources/media/dump_creator.js

Issue 2816523002: Update text about diagnostic audio recordings on chrome://webrtc-internals. (Closed)
Patch Set: Code review. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 5
6 /** 6 /**
7 * Provides the UI for dump creation. 7 * Provides the UI for dump creation.
8 */ 8 */
9 var DumpCreator = (function() { 9 var DumpCreator = (function() {
10 /** 10 /**
(...skipping 16 matching lines...) Expand all
27 summary.textContent = 'Create Dump'; 27 summary.textContent = 'Create Dump';
28 var content = document.createElement('div'); 28 var content = document.createElement('div');
29 this.root_.appendChild(content); 29 this.root_.appendChild(content);
30 30
31 content.innerHTML = '<div><a><button>' + 31 content.innerHTML = '<div><a><button>' +
32 'Download the PeerConnection updates and stats data' + 32 'Download the PeerConnection updates and stats data' +
33 '</button></a></div>' + 33 '</button></a></div>' +
34 '<p><label><input type=checkbox>' + 34 '<p><label><input type=checkbox>' +
35 'Enable diagnostic audio recordings</label></p>' + 35 'Enable diagnostic audio recordings</label></p>' +
36 '<p class=audio-diagnostic-dumps-info>A diagnostic audio recording is' + 36 '<p class=audio-diagnostic-dumps-info>A diagnostic audio recording is' +
37 ' used for analyzing audio problems. It consists of two files and' + 37 ' used for analyzing audio problems. It consists of several files and' +
38 ' contains the audio played out from the speaker and recorded from' + 38 ' contains the audio played out to the speaker (output) and captured' +
39 ' the microphone and is saved to the local disk. Checking this box' + 39 ' from the microphone (input). The data is saved to the local disk.' +
tommi (sloooow) - chröme 2017/05/17 07:34:20 nit: "The data is saved locally."
Henrik Grunell 2017/05/30 10:39:53 Done.
40 ' will enable the recording for ongoing WebRTC calls and for future' + 40 ' Checking this box will enable recordings of all ongoing input and' +
41 ' WebRTC calls. When the box is unchecked or this page is closed, all' + 41 ' output audio streams (including non-WebRTC streams) and for future' +
42 ' ongoing recordings will be stopped and this recording' + 42 ' audio streams. When the box is unchecked or this page is closed,' +
43 ' functionality will be disabled for future WebRTC calls. Recordings' + 43 ' all ongoing recordings will be stopped and this recording' +
44 ' in multiple tabs are supported as well as multiple recordings in' + 44 ' functionality disabled. Recording audio from multiple tabs is' +
45 ' the same tab. When enabling, you select a base filename to which' + 45 ' supported as well as multiple recordings from the same tab. When' +
tommi (sloooow) - chröme 2017/05/17 07:34:20 nit: Would be nice to add a line break or end the
Henrik Grunell 2017/05/30 10:39:53 SG, done.
46 ' suffixes will be appended as</p>' + 46 ' enabling, select a base filename to which the following suffixes' +
47 ' will be added:</p>' +
47 '<p><div>&lt;base filename&gt;.&lt;render process ID&gt;' + 48 '<p><div>&lt;base filename&gt;.&lt;render process ID&gt;' +
48 '.aec_dump.&lt;recording ID&gt;</div>' + 49 '.aec_dump.&lt;AEC dump recording ID&gt;</div>' +
49 '<div>&lt;base filename&gt;.&lt;render process ID&gt;' + 50 '<div>&lt;base filename&gt;.&lt;render process ID&gt;' +
50 '.source_input.&lt;stream ID&gt;.wav</div></p>' + 51 '.source_input.&lt;stream ID&gt;.wav</div>' +
51 '<p class=audio-diagnostic-dumps-info>If recordings are disabled and' + 52 '<div>&lt;base filename&gt;.output' +
52 ' then enabled using the same base filename, the microphone recording' + 53 '.&lt;output stream recording ID&gt;.wav</div></p>' +
53 ' file will be overwritten, and the AEC dump file will be appended to' + 54 '<p class=audio-diagnostic-dumps-info>It is recommended to choose a' +
54 ' and may become invalid. It is recommended to choose a new base' + 55 ' new base filename each time the feature is enabled to avoid ending' +
55 ' filename each time or move the produced files before enabling' + 56 ' up with partially overwritten or unusable audio files.</p>' +
56 ' again.</p>' +
57 '<p><label><input type=checkbox>' + 57 '<p><label><input type=checkbox>' +
58 'Enable diagnostic packet and event recording</label></p>' + 58 'Enable diagnostic packet and event recording</label></p>' +
59 '<p class=audio-diagnostic-dumps-info>A diagnostic packet and event' + 59 '<p class=audio-diagnostic-dumps-info>A diagnostic packet and event' +
60 ' recording can be used for analyzing various issues related to' + 60 ' recording can be used for analyzing various issues related to' +
61 ' thread starvation, jitter buffers or bandwidth estimation. Two' + 61 ' thread starvation, jitter buffers or bandwidth estimation. Two' +
62 ' types of data are logged. First, incoming and outgoing RTP headers' + 62 ' types of data are logged. First, incoming and outgoing RTP headers' +
63 ' and RTCP packets are logged. These do not include any audio or' + 63 ' and RTCP packets are logged. These do not include any audio or' +
64 ' video information, nor any other types of personally identifiable' + 64 ' video information, nor any other types of personally identifiable' +
65 ' information (so no IP addresses or URLs). Checking this box will' + 65 ' information (so no IP addresses or URLs). Checking this box will' +
66 ' enable the recording for ongoing WebRTC calls and for future' + 66 ' enable the recording for ongoing WebRTC calls and for future' +
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 var enabled = this.root_.getElementsByTagName('input')[1].checked; 153 var enabled = this.root_.getElementsByTagName('input')[1].checked;
154 if (enabled) { 154 if (enabled) {
155 chrome.send('enableEventLogRecordings'); 155 chrome.send('enableEventLogRecordings');
156 } else { 156 } else {
157 chrome.send('disableEventLogRecordings'); 157 chrome.send('disableEventLogRecordings');
158 } 158 }
159 }, 159 },
160 }; 160 };
161 return DumpCreator; 161 return DumpCreator;
162 })(); 162 })();
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698