Update text about diagnostic audio recordings on chrome://webrtc-internals.

content/browser/resources/media/dump_creator.js

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 
 /**
  * Provides the UI for dump creation.
  */
 var DumpCreator = (function() {
   /**
@@ skipping 16 matching lines @@
     summary.textContent = 'Create Dump';
     var content = document.createElement('div');
     this.root_.appendChild(content);
 
     content.innerHTML = '<div><a><button>' +
         'Download the PeerConnection updates and stats data' +
         '</button></a></div>' +
         '<p><label><input type=checkbox>' +
         'Enable diagnostic audio recordings</label></p>' +
         '<p class=audio-diagnostic-dumps-info>A diagnostic audio recording is' +
-        ' used for analyzing audio problems. It consists of two files and' +
-        ' contains the audio played out from the speaker and recorded from' +
+        ' used for analyzing audio problems. It consists of several files and' +
+        ' contains the audio played out to the speaker and recorded from' +

[tommi (sloooow) - chröme, 2017/05/03 09:12:12]

nit: could replace the last 'and' with a comma.

[Henrik Grunell, 2017/05/12 12:20:18]

Hmm, that seems awkward too. Changed the "saved to" statement to its own
sentence instead, have a look.

         ' the microphone and is saved to the local disk. Checking this box' +
-        ' will enable the recording for ongoing WebRTC calls and for future' +
-        ' WebRTC calls. When the box is unchecked or this page is closed, all' +
-        ' ongoing recordings will be stopped and this recording' +
-        ' functionality will be disabled for future WebRTC calls. Recordings' +
-        ' in multiple tabs are supported as well as multiple recordings in' +
-        ' the same tab. When enabling, you select a base filename to which' +
-        ' suffixes will be appended as</p>' +
+        ' will enable the recording for ongoing WebRTC calls, all ongoing' +

[tommi (sloooow) - chröme, 2017/05/03 09:12:12]

"recording of ongoing"

[Henrik Grunell, 2017/05/12 12:20:18]

Done.

+        ' playout streams (also non-WebRTC), all ongoing recording streams' +

[tommi (sloooow) - chröme, 2017/05/03 09:12:11]

"(including non-WebRTC)"

It's not clear to me what 'recording streams' means here, since that seems to
indicate that we're recording a recording?  Does this relate to a particular
API?

[Henrik Grunell, 2017/05/12 12:20:17]

Done.
Good point. "record[ing]" refers to mic input here. Changed to "output" and
"input".

Changed to only use "record" and "recording" for the recording to file
throughout the text. Using "input" or "capture" for notifying mic side.

+        ' (also non-WebRTC) and for future WebRTC calls and streams. When the' +

[tommi (sloooow) - chröme, 2017/05/03 09:12:12]

nit: you could replace "calls and" with "audio" -> "for future WebRTC audio
streams"

[Henrik Grunell, 2017/05/12 12:20:18]

WebRTC call would refer to the AEC dump, which is WebRTC specific. This is
getting confusing. It's better to just write input and output streams; the AEC
dump data is part of the streams pipeline. Changed, wdyt?

+        ' box is unchecked or this page is closed, all ongoing recordings' +

[tommi (sloooow) - chröme, 2017/05/03 09:12:11]

'this page is closed'  Does that stop an ongoing recording?  I wasn't aware of
that, so just double checking if that's true.

[Henrik Grunell, 2017/05/12 12:20:17]

Yes, it's (still) true. I verified just now.

+        ' will be stopped and this recording functionality will be disabled' +

[tommi (sloooow) - chröme, 2017/05/03 09:12:12]

nit: "the recording functionality disabled"

[Henrik Grunell, 2017/05/12 12:20:17]

Done.

+        ' for future WebRTC calls and streams. Recordings in multiple tabs' +

[tommi (sloooow) - chröme, 2017/05/03 09:12:11]

I'd skip "fore future WebRTC calls and streams" since it actually makes things a
little less clear in my opinion. The first part of the sentence talks about
'ongoing' whereas the last part talks about 'future'.  I think that the middle
part where it says 'recording functionality will be disabled', already covers
the 'future' part.

[tommi (sloooow) - chröme, 2017/05/03 09:12:12]

"Recordings in multiple tabs" doesn't sound right.  Suggest "Recording audio
from multiple tabs is supported" instead.

[Henrik Grunell, 2017/05/12 12:20:17]

Done.

[Henrik Grunell, 2017/05/12 12:20:18]

Sounds good. Done.

+        ' are supported as well as multiple recordings in the same tab. When' +

[tommi (sloooow) - chröme, 2017/05/03 09:12:11]

"from the same tab"

[Henrik Grunell, 2017/05/12 12:20:17]

Done.

+        ' enabling, you select a base filename to which suffixes will be' +

[tommi (sloooow) - chröme, 2017/05/03 09:12:11]

remove "you "
Also suggest: "to which the following suffixes will be added:"

[Henrik Grunell, 2017/05/12 12:20:17]

Good suggestions. Done.

+        ' appended as</p>' +
         '<p><div>&lt;base filename&gt;.&lt;render process ID&gt;' +
-        '.aec_dump.&lt;recording ID&gt;</div>' +
+        '.aec_dump.&lt;AEC dump recording ID&gt;</div>' +
         '<div>&lt;base filename&gt;.&lt;render process ID&gt;' +
-        '.source_input.&lt;stream ID&gt;.wav</div></p>' +
+        '.source_input.&lt;stream ID&gt;.wav</div>' +
+        '<div>&lt;base filename&gt;.output' +
+        '.&lt;output stream recording ID&gt;.wav</div></p>' +
         '<p class=audio-diagnostic-dumps-info>If recordings are disabled and' +

[tommi (sloooow) - chröme, 2017/05/03 09:12:11]

'recordings are disabled' also doesn't sound right. The recordings themselves
cannot be disabled, the feature can though. Hmm.. it's subtle. I think that it
might be a good idea to have a native english speaker read this over and
rephrase. As we're making small changes here and there, I think the overall flow
of the text, gets altered and possibly less clear.

[Henrik Grunell, 2017/05/12 12:20:17]

Good point. Also agree it would be good having a native speaker go over this.
Now I updated based on what you pointed out.

         ' then enabled using the same base filename, the microphone recording' +

[tommi (sloooow) - chröme, 2017/05/03 09:12:12]

re-enabled

[Henrik Grunell, 2017/05/12 12:20:18]

Done.

-        ' file will be overwritten, and the AEC dump file will be appended to' +
-        ' and may become invalid. It is recommended to choose a new base' +
-        ' filename each time or move the produced files before enabling' +
-        ' again.</p>' +
+        ' files (&quot;source_input&quot;) will be overwritten, and the AEC' +

[tommi (sloooow) - chröme, 2017/05/03 09:12:12]

instead of "the microphone recording files", I'd just say "the audio files". 
I'd also put the parenthesis before 'audio files'.
I'd also suggest putting a period after 'overwritten' and start the next
sentence with "The AEC dump file..."

[Henrik Grunell, 2017/05/12 12:20:17]

Done.

+        ' dump file will be appended to and may become invalid. It is' +

[tommi (sloooow) - chröme, 2017/05/03 09:12:12]

this isn't really clear.  "and the AEC dump file will be appended to and may
become invalid." 
I think the subject may have gotten lost. (appended to what? the previous files?
are the new files not fresh in the sense that appending is incorrect?)

[Henrik Grunell, 2017/05/12 12:20:17]

Appending to the previous file. Changed wording.

+        ' recommended to choose a new base filename each time or move the' +

[tommi (sloooow) - chröme, 2017/05/03 09:12:11]

Perhaps it might be best to simply say something like.  "It is recommended to
choose a new base filename each time the feature is enabled [or turned on] to
avoid ending up with partially overwritten or unusable audio files."  I feel the
whole thing is otherwise hard to parse.

[Henrik Grunell, 2017/05/12 12:20:17]

Yes, I think that's a good idea. Done.

+        ' produced files before enabling again.</p>' +
         '<p><label><input type=checkbox>' +
         'Enable diagnostic packet and event recording</label></p>' +
         '<p class=audio-diagnostic-dumps-info>A diagnostic packet and event' +
         ' recording can be used for analyzing various issues related to' +
         ' thread starvation, jitter buffers or bandwidth estimation. Two' +
         ' types of data are logged. First, incoming and outgoing RTP headers' +
         ' and RTCP packets are logged. These do not include any audio or' +
         ' video information, nor any other types of personally identifiable' +
         ' information (so no IP addresses or URLs). Checking this box will' +
         ' enable the recording for ongoing WebRTC calls and for future' +
@@ skipping 86 matching lines @@
       var enabled = this.root_.getElementsByTagName('input')[1].checked;
       if (enabled) {
         chrome.send('enableEventLogRecordings');
       } else {
         chrome.send('disableEventLogRecordings');
       }
     },
   };
   return DumpCreator;
 })();