Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1038)

Unified Diff: components/ntp_snippets/pref_util.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/pref_util.cc
diff --git a/components/ntp_snippets/pref_util.cc b/components/ntp_snippets/pref_util.cc
index 3973cda1b1d53a01b50ae949675412d1c1eb5154..a6288f925356110976fab3ff423790530d283e11 100644
--- a/components/ntp_snippets/pref_util.cc
+++ b/components/ntp_snippets/pref_util.cc
@@ -16,9 +16,9 @@
const std::string& pref_name) {
std::set<std::string> dismissed_ids;
const base::ListValue* list = pref_service.GetList(pref_name);
- for (const base::Value& value : *list) {
+ for (const std::unique_ptr<base::Value>& value : *list) {
std::string dismissed_id;
- bool success = value.GetAsString(&dismissed_id);
+ bool success = value->GetAsString(&dismissed_id);
DCHECK(success) << "Failed to parse dismissed id from prefs param "
<< pref_name << " into string.";
dismissed_ids.insert(dismissed_id);
« no previous file with comments | « components/ntp_snippets/content_suggestions_service.cc ('k') | components/ntp_snippets/remote/remote_suggestion.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698