Revert of Change base::Value::ListStorage to std::vector<base::Value>

extensions/browser/api/declarative/declarative_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/declarative/declarative_api.h"
 
 #include <stddef.h>
 
 #include "base/base64.h"
 #include "base/bind.h"
@@ skipping 37 matching lines @@
   return std::unique_ptr<base::Value>(new base::Value(data64));
 }
 
 // Parses through |args| replacing any BinaryValues with base64 encoded
 // StringValues. Recurses over any nested ListValues, and calls
 // ConvertBinaryDictionaryValuesToBase64 for any nested DictionaryValues.
 void ConvertBinaryListElementsToBase64(base::ListValue* args) {
   size_t index = 0;
   for (base::ListValue::iterator iter = args->begin(); iter != args->end();
        ++iter, ++index) {
-    if (iter->IsType(base::Value::Type::BINARY)) {
+    if ((*iter)->IsType(base::Value::Type::BINARY)) {
       base::Value* binary = NULL;
       if (args->GetBinary(index, &binary))
         args->Set(index, ConvertBinaryToBase64(binary).release());
-    } else if (iter->IsType(base::Value::Type::LIST)) {
+    } else if ((*iter)->IsType(base::Value::Type::LIST)) {
       base::ListValue* list;
-      iter->GetAsList(&list);
+      (*iter)->GetAsList(&list);
       ConvertBinaryListElementsToBase64(list);
-    } else if (iter->IsType(base::Value::Type::DICTIONARY)) {
+    } else if ((*iter)->IsType(base::Value::Type::DICTIONARY)) {
       base::DictionaryValue* dict;
-      iter->GetAsDictionary(&dict);
+      (*iter)->GetAsDictionary(&dict);
       ConvertBinaryDictionaryValuesToBase64(dict);
     }
   }
 }
 
 // Parses through |dict| replacing any BinaryValues with base64 encoded
 // StringValues. Recurses over any nested DictionaryValues, and calls
 // ConvertBinaryListElementsToBase64 for any nested ListValues.
 void ConvertBinaryDictionaryValuesToBase64(base::DictionaryValue* dict) {
   for (base::DictionaryValue::Iterator iter(*dict); !iter.IsAtEnd();
@@ skipping 139 matching lines @@
 
   std::unique_ptr<base::ListValue> rules_value(new base::ListValue());
   for (const auto& rule : rules)
     rules_value->Append(rule->ToValue());
   SetResult(std::move(rules_value));
 
   return true;
 }
 
 }  // namespace extensions