Revert of Change base::Value::ListStorage to std::vector<base::Value>

chrome/common/extensions/api/extension_action/action_info.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/api/extension_action/action_info.h"
 
 #include <memory>
 
 #include "base/memory/ptr_util.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 50 matching lines @@
   std::unique_ptr<ActionInfo> result(new ActionInfo());
 
   if (extension->manifest_version() == 1) {
     // kPageActionIcons is obsolete, and used by very few extensions. Continue
     // loading it, but only take the first icon as the default_icon path.
     const base::ListValue* icons = NULL;
     if (dict->HasKey(keys::kPageActionIcons) &&
         dict->GetList(keys::kPageActionIcons, &icons)) {
       base::ListValue::const_iterator iter = icons->begin();
       std::string path;
-      if (iter == icons->end() || !iter->GetAsString(&path) ||
+      if (iter == icons->end() ||
+          !(*iter)->GetAsString(&path) ||
           !manifest_handler_helpers::NormalizeAndValidatePath(&path)) {
         *error = base::ASCIIToUTF16(errors::kInvalidPageActionIconPath);
         return std::unique_ptr<ActionInfo>();
       }
       // Extension icons were 19 DIP when kPageActionIcons was supported.
       result->default_icon.Add(19, path);
     }
 
     std::string id;
     if (dict->HasKey(keys::kPageActionId)) {
@@ skipping 134 matching lines @@
 
 // static
 bool ActionInfo::IsVerboseInstallMessage(const Extension* extension) {
   const ActionInfo* page_action_info = GetPageActionInfo(extension);
   return page_action_info &&
       (CommandsInfo::GetPageActionCommand(extension) ||
        !page_action_info->default_icon.empty());
 }
 
 }  // namespace extensions