Revert of Change base::Value::ListStorage to std::vector<base::Value>

chrome/browser/spellchecker/spellcheck_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/spellchecker/spellcheck_service.h"
 
 #include <set>
 
 #include "base/logging.h"
 #include "base/strings/string_split.h"
@@ skipping 109 matching lines @@
 
 #if !defined(OS_MACOSX)
 // static
 void SpellcheckService::GetDictionaries(base::SupportsUserData* browser_context,
                                         std::vector<Dictionary>* dictionaries) {
   PrefService* prefs = user_prefs::UserPrefs::Get(browser_context);
   std::set<std::string> spellcheck_dictionaries;
   for (const auto& value :
        *prefs->GetList(spellcheck::prefs::kSpellCheckDictionaries)) {
     std::string dictionary;
-    if (value.GetAsString(&dictionary))
+    if (value->GetAsString(&dictionary))
       spellcheck_dictionaries.insert(dictionary);
   }
 
   dictionaries->clear();
   std::vector<std::string> accept_languages =
       base::SplitString(prefs->GetString(prefs::kAcceptLanguages), ",",
                         base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
   for (const auto& accept_language : accept_languages) {
     Dictionary dictionary;
     dictionary.language =
@@ skipping 68 matching lines @@
   hunspell_dictionaries_.clear();
 
   PrefService* prefs = user_prefs::UserPrefs::Get(context_);
   DCHECK(prefs);
 
   const base::ListValue* dictionary_values =
       prefs->GetList(spellcheck::prefs::kSpellCheckDictionaries);
 
   for (const auto& dictionary_value : *dictionary_values) {
     std::string dictionary;
-    dictionary_value.GetAsString(&dictionary);
+    dictionary_value->GetAsString(&dictionary);
     hunspell_dictionaries_.push_back(
         base::MakeUnique<SpellcheckHunspellDictionary>(
             dictionary,
             content::BrowserContext::GetDefaultStoragePartition(context_)
                 ->GetURLRequestContext(),
             this));
     hunspell_dictionaries_.back()->AddObserver(this);
     hunspell_dictionaries_.back()->Load();
   }
 }
@@ skipping 112 matching lines @@
 
   for (const auto& dictionary : dictionaries) {
     if (std::find(accept_languages.begin(), accept_languages.end(),
                   dictionary) != accept_languages.end()) {
       filtered_dictionaries.push_back(dictionary);
     }
   }
 
   dictionaries_pref.SetValue(filtered_dictionaries);
 }