ios/chrome/browser/ui/ntp/new_tab_page_controller.mm - Issue 2816383002: Remove non-const version of GetDefaultSearchProvider() and make all callers call the const version

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/ntp/new_tab_page_controller.mm

Issue 2816383002: Remove non-const version of GetDefaultSearchProvider() and make all callers call the const version (Closed)

Patch Set: Fix instant extended interactive ui test for calling the const version of GetDefaultSearchProvider() Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/ui/ntp/new_tab_page_controller.mm

diff --git a/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm b/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm

index 21d0df203f3b9301612a86ed86825bebb9facb0e..5d987b3da893194c9bda196dc9caa5c175761ee9 100644

--- a/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm

+++ b/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm

@@ -335,7 +335,7 @@ enum {

TemplateURLService* service =

ios::TemplateURLServiceFactory::GetForBrowserState(browserState_);

if (service) {

- TemplateURL* defaultURL = service->GetDefaultSearchProvider();

+ const TemplateURL* defaultURL = service->GetDefaultSearchProvider();

if (defaultURL &&

defaultURL->GetEngineType(service->search_terms_data()) !=

SEARCH_ENGINE_GOOGLE) {