Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1330)

Side by Side Diff: components/search_engines/template_url_service.cc

Issue 2816383002: Remove non-const version of GetDefaultSearchProvider() and make all callers call the const version (Closed)
Patch Set: Fix compiler error for iOS build by calling the const version of TemplateURLService::GetDefaultSear… Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/search_engines/template_url_service.h" 5 #include "components/search_engines/template_url_service.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/auto_reset.h" 10 #include "base/auto_reset.h"
(...skipping 586 matching lines...) Expand 10 before | Expand all | Expand 10 after
597 } else { 597 } else {
598 // We rely on the DefaultSearchManager to call OnDefaultSearchChange if, in 598 // We rely on the DefaultSearchManager to call OnDefaultSearchChange if, in
599 // fact, the effective DSE changes. 599 // fact, the effective DSE changes.
600 if (url) 600 if (url)
601 default_search_manager_.SetUserSelectedDefaultSearchEngine(url->data()); 601 default_search_manager_.SetUserSelectedDefaultSearchEngine(url->data());
602 else 602 else
603 default_search_manager_.ClearUserSelectedDefaultSearchEngine(); 603 default_search_manager_.ClearUserSelectedDefaultSearchEngine();
604 } 604 }
605 } 605 }
606 606
607 TemplateURL* TemplateURLService::GetDefaultSearchProvider() {
608 return const_cast<TemplateURL*>(
609 static_cast<const TemplateURLService*>(this)->GetDefaultSearchProvider());
610 }
611
612 const TemplateURL* TemplateURLService::GetDefaultSearchProvider() const { 607 const TemplateURL* TemplateURLService::GetDefaultSearchProvider() const {
613 return loaded_ ? default_search_provider_ 608 return loaded_ ? default_search_provider_
614 : initial_default_search_provider_.get(); 609 : initial_default_search_provider_.get();
615 } 610 }
616 611
617 bool TemplateURLService::IsSearchResultsPageFromDefaultSearchProvider( 612 bool TemplateURLService::IsSearchResultsPageFromDefaultSearchProvider(
618 const GURL& url) const { 613 const GURL& url) const {
619 const TemplateURL* default_provider = GetDefaultSearchProvider(); 614 const TemplateURL* default_provider = GetDefaultSearchProvider();
620 return default_provider && 615 return default_provider &&
621 default_provider->IsSearchURL(url, search_terms_data()); 616 default_provider->IsSearchURL(url, search_terms_data());
(...skipping 1868 matching lines...) Expand 10 before | Expand all | Expand 10 after
2490 if (!IsCreatedByExtension(template_url.get())) { 2485 if (!IsCreatedByExtension(template_url.get())) {
2491 if (keyword_to_template_url.find(template_url->keyword()) != 2486 if (keyword_to_template_url.find(template_url->keyword()) !=
2492 keyword_to_template_url.end()) { 2487 keyword_to_template_url.end()) {
2493 return true; 2488 return true;
2494 } 2489 }
2495 keyword_to_template_url[template_url->keyword()] = template_url.get(); 2490 keyword_to_template_url[template_url->keyword()] = template_url.get();
2496 } 2491 }
2497 } 2492 }
2498 return false; 2493 return false;
2499 } 2494 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698