Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: net/cert/ct_objects_extractor_unittest.cc

Issue 2816363002: Reimplement ct_objects_extractor.cc without legacy ASN.1 code (Closed)
Patch Set: appease MSVC Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/cert/ct_objects_extractor.cc ('K') | « net/cert/ct_objects_extractor.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/ct_objects_extractor_unittest.cc
diff --git a/net/cert/ct_objects_extractor_unittest.cc b/net/cert/ct_objects_extractor_unittest.cc
index 107364511dec47f320ece47647d966840bf94cdb..b53bee5386846d3594d3c34cdf2d26b624cd9785 100644
--- a/net/cert/ct_objects_extractor_unittest.cc
+++ b/net/cert/ct_objects_extractor_unittest.cc
@@ -40,12 +40,12 @@ class CTObjectsExtractorTest : public ::testing::Test {
void ExtractEmbeddedSCT(scoped_refptr<X509Certificate> cert,
scoped_refptr<SignedCertificateTimestamp>* sct) {
std::string sct_list;
- EXPECT_TRUE(ExtractEmbeddedSCTList(cert->os_cert_handle(), &sct_list));
+ ASSERT_TRUE(ExtractEmbeddedSCTList(cert->os_cert_handle(), &sct_list));
std::vector<base::StringPiece> parsed_scts;
- base::StringPiece sct_list_sp(sct_list);
// Make sure the SCT list can be decoded properly
- EXPECT_TRUE(DecodeSCTList(sct_list_sp, &parsed_scts));
+ ASSERT_TRUE(DecodeSCTList(sct_list, &parsed_scts));
+ ASSERT_EQ(1u, parsed_scts.size());
EXPECT_TRUE(DecodeSignedCertificateTimestamp(&parsed_scts[0], sct));
}
« net/cert/ct_objects_extractor.cc ('K') | « net/cert/ct_objects_extractor.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698