Reimplement ct_objects_extractor.cc without legacy ASN.1 code

net/cert/ct_objects_extractor_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert/ct_objects_extractor.h"
 
 #include "base/files/file_path.h"
 #include "net/cert/ct_log_verifier.h"
 #include "net/cert/ct_serialization.h"
 #include "net/cert/signed_certificate_timestamp.h"
@@ skipping 22 matching lines @@
     ASSERT_TRUE(test_cert_);
 
     log_ = CTLogVerifier::Create(ct::GetTestPublicKey(), "testlog",
                                  "https://ct.example.com", "dns.example.com");
     ASSERT_TRUE(log_);
   }
 
   void ExtractEmbeddedSCT(scoped_refptr<X509Certificate> cert,
                           scoped_refptr<SignedCertificateTimestamp>* sct) {
     std::string sct_list;
-    EXPECT_TRUE(ExtractEmbeddedSCTList(cert->os_cert_handle(), &sct_list));
+    ASSERT_TRUE(ExtractEmbeddedSCTList(cert->os_cert_handle(), &sct_list));
 
     std::vector<base::StringPiece> parsed_scts;
-    base::StringPiece sct_list_sp(sct_list);
     // Make sure the SCT list can be decoded properly
-    EXPECT_TRUE(DecodeSCTList(sct_list_sp, &parsed_scts));
+    ASSERT_TRUE(DecodeSCTList(sct_list, &parsed_scts));
+    ASSERT_EQ(1u, parsed_scts.size());
     EXPECT_TRUE(DecodeSignedCertificateTimestamp(&parsed_scts[0], sct));
   }
 
  protected:
   CertificateList precert_chain_;
   scoped_refptr<X509Certificate> test_cert_;
   scoped_refptr<const CTLogVerifier> log_;
 };
 
 // Test that an SCT can be extracted and the extracted SCT contains the
@@ skipping 118 matching lines @@
   std::string extracted_sct_list;
   // Use test_cert_ for issuer - it is not the correct issuer of |subject_cert|.
   EXPECT_FALSE(ct::ExtractSCTListFromOCSPResponse(
       test_cert_->os_cert_handle(), subject_cert->serial_number(),
       ocsp_response, &extracted_sct_list));
 }
 
 }  // namespace ct
 
 }  // namespace net