Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: chrome/browser/ui/views/extensions/request_file_system_dialog_view.h

Issue 2816293002: Description: Replace layout constants in chrome/browser/extensions and chrome/browser/first_run (Closed)
Patch Set: Fix dumb error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/request_file_system_dialog_view.h
diff --git a/chrome/browser/extensions/api/file_system/request_file_system_dialog_view.h b/chrome/browser/ui/views/extensions/request_file_system_dialog_view.h
similarity index 82%
rename from chrome/browser/extensions/api/file_system/request_file_system_dialog_view.h
rename to chrome/browser/ui/views/extensions/request_file_system_dialog_view.h
index f113f0b72d8172effc2b80e427ff3ef25ad78d1c..27641c145c417605cf95afba49b811c5434c1dca 100644
--- a/chrome/browser/extensions/api/file_system/request_file_system_dialog_view.h
+++ b/chrome/browser/ui/views/extensions/request_file_system_dialog_view.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_EXTENSIONS_API_FILE_SYSTEM_REQUEST_FILE_SYSTEM_DIALOG_VIEW_H_
-#define CHROME_BROWSER_EXTENSIONS_API_FILE_SYSTEM_REQUEST_FILE_SYSTEM_DIALOG_VIEW_H_
+#ifndef CHROME_BROWSER_UI_VIEWS_EXTENSIONS_REQUEST_FILE_SYSTEM_DIALOG_VIEW_H_
+#define CHROME_BROWSER_UI_VIEWS_EXTENSIONS_REQUEST_FILE_SYSTEM_DIALOG_VIEW_H_
#include "base/callback_forward.h"
#include "base/macros.h"
@@ -27,7 +27,7 @@ class View;
} // namespace views
// Represents a dialog shown to a user for granting access to a file system.
-class RequestFileSystemDialogView : public views::DialogDelegate {
+class RequestFileSystemDialogView : public views::DialogDelegateView {
public:
~RequestFileSystemDialogView() override;
@@ -44,12 +44,13 @@ class RequestFileSystemDialogView : public views::DialogDelegate {
int GetDefaultDialogButton() const override;
base::string16 GetDialogButtonLabel(ui::DialogButton button) const override;
ui::ModalType GetModalType() const override;
- views::View* GetContentsView() override;
- views::Widget* GetWidget() override;
- const views::Widget* GetWidget() const override;
bool Cancel() override;
bool Accept() override;
+ // View overrides:
Peter Kasting 2017/04/26 18:26:25 Nit: You don't subclass View, just DialogDelegateV
ananta 2017/04/26 19:42:21 Done.
+ gfx::Size GetPreferredSize() const override;
+ gfx::Insets GetInsets() const override;
+
private:
RequestFileSystemDialogView(
const extensions::Extension& extension,
@@ -63,4 +64,4 @@ class RequestFileSystemDialogView : public views::DialogDelegate {
DISALLOW_COPY_AND_ASSIGN(RequestFileSystemDialogView);
};
-#endif // CHROME_BROWSER_EXTENSIONS_API_FILE_SYSTEM_REQUEST_FILE_SYSTEM_DIALOG_VIEW_H_
+#endif // CHROME_BROWSER_UI_VIEWS_EXTENSIONS_REQUEST_FILE_SYSTEM_DIALOG_VIEW_H_

Powered by Google App Engine
This is Rietveld 408576698