Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 281623007: Add mojo web UI framework based on Nat's TVCM (Closed)

Created:
6 years, 7 months ago by cpu_(ooo_6.6-7.5)
Modified:
6 years, 7 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add mojo web UI framework based on Nat's TVCM TVCM is what chrome-tracing uses. TBR=viettrungluu BUG=360188 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270281

Patch Set 1 #

Patch Set 2 : vtl nits #

Patch Set 3 : missed a few #

Unified diffs Side-by-side diffs Delta from patch set Stats (+431 lines, -35 lines) Patch
A + mojo/spy/PRESUBMIT.py View 1 1 chunk +3 lines, -22 lines 0 comments Download
A mojo/spy/run_ui_dev_server View 1 1 chunk +22 lines, -0 lines 0 comments Download
A mojo/spy/run_ui_tests View 1 1 chunk +23 lines, -0 lines 0 comments Download
A + mojo/spy/ui/__init__.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + mojo/spy/ui/dev_server.py View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
A mojo/spy/ui/spy.html View 1 1 chunk +36 lines, -0 lines 0 comments Download
A mojo/spy/ui/spy.js View 1 2 1 chunk +96 lines, -0 lines 0 comments Download
A mojo/spy/ui/spy_project.py View 1 1 chunk +18 lines, -0 lines 0 comments Download
A mojo/spy/ui/spy_shell.html View 1 1 chunk +39 lines, -0 lines 0 comments Download
A mojo/spy/ui/spy_shell.js View 1 1 chunk +68 lines, -0 lines 0 comments Download
A + mojo/spy/ui/spy_shell_to_html View 1 2 1 chunk +6 lines, -3 lines 0 comments Download
A mojo/spy/ui/spy_shell_to_html.py View 1 1 chunk +39 lines, -0 lines 0 comments Download
A mojo/spy/ui/spy_test.js View 1 2 1 chunk +51 lines, -0 lines 0 comments Download
A mojo/spy/ui/tvcm_stub.py View 1 1 chunk +18 lines, -0 lines 0 comments Download
A + mojo/spy/ui/ui_unittest.py View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
cpu_(ooo_6.6-7.5)
this is the very same CL as https://codereview.chromium.org/278703002/ which has been reviewed already. I am ...
6 years, 7 months ago (2014-05-13 20:35:42 UTC) #1
cpu_(ooo_6.6-7.5)
The CQ bit was checked by cpu@chromium.org
6 years, 7 months ago (2014-05-13 22:02:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/281623007/40001
6 years, 7 months ago (2014-05-13 22:09:51 UTC) #3
viettrungluu
lgtm
6 years, 7 months ago (2014-05-13 23:16:31 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-14 01:12:42 UTC) #5
Message was sent while issue was closed. 
Change committed as 270281

Powered by Google App Engine
This is Rietveld 408576698