chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc - Issue 2816193002: Introduce a type of View background that stays in sync with its host

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc

Issue 2816193002: Introduce a type of View background that stays in sync with its host (Closed)

Patch Set: tdanderson review + rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/system/user/user_view.cc ('K') | « ash/system/user/user_view.cc ('k') | chrome/browser/ui/views/location_bar/location_bar_view.cc » ('j') | chrome/browser/ui/views/location_bar/location_bar_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc

diff --git a/chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc b/chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc

index addc3e0e9a2734b44e38d2967e0aa64b8189c6ab..6970f7df1c7d7aa85010fc9afa81ab6adacfee2d 100644

--- a/chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc

+++ b/chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc

@@ -155,9 +155,8 @@ PasswordGenerationPopupViewViews::PasswordGenerationPopupViewViews(

PasswordGenerationPopupController::kHorizontalPadding));

AddChildView(help_label_);

- set_background(views::Background::CreateSolidBackground(

- GetNativeTheme()->GetSystemColor(

- ui::NativeTheme::kColorId_ResultsTableNormalBackground)));

+ set_background(views::Background::CreateThemedSolidBackground(

+ this, ui::NativeTheme::kColorId_ResultsTableNormalBackground));

}

PasswordGenerationPopupViewViews::~PasswordGenerationPopupViewViews() {}

@@ -212,12 +211,11 @@ void PasswordGenerationPopupViewViews::PasswordSelectionUpdated() {

if (controller_->password_selected())

NotifyAccessibilityEvent(ui::AX_EVENT_SELECTION, true);

- password_view_->set_background(

- views::Background::CreateSolidBackground(

- GetNativeTheme()->GetSystemColor(

- controller_->password_selected() ?

- ui::NativeTheme::kColorId_ResultsTableHoveredBackground :

- ui::NativeTheme::kColorId_ResultsTableNormalBackground)));

+ password_view_->set_background(views::Background::CreateThemedSolidBackground(

+ password_view_,

+ controller_->password_selected()

+ ? ui::NativeTheme::kColorId_ResultsTableHoveredBackground

+ : ui::NativeTheme::kColorId_ResultsTableNormalBackground));

}

void PasswordGenerationPopupViewViews::Layout() {