Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: ash/system/tray/tray_popup_utils.cc

Issue 2816193002: Introduce a type of View background that stays in sync with its host (Closed)
Patch Set: tdanderson review + rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/system/tray/tray_popup_utils.cc
diff --git a/ash/system/tray/tray_popup_utils.cc b/ash/system/tray/tray_popup_utils.cc
index c2d5237d92fcfe072bc2f948afac515501afd9c2..a51aac768e58c8ab60ee6b5ce861ebf3f6a7f83d 100644
--- a/ash/system/tray/tray_popup_utils.cc
+++ b/ash/system/tray/tray_popup_utils.cc
@@ -21,6 +21,7 @@
#include "ui/base/l10n/l10n_util.h"
#include "ui/gfx/color_palette.h"
#include "ui/gfx/paint_vector_icon.h"
+#include "ui/native_theme/native_theme.h"
#include "ui/views/animation/flood_fill_ink_drop_ripple.h"
#include "ui/views/animation/ink_drop_highlight.h"
#include "ui/views/animation/ink_drop_impl.h"
@@ -211,9 +212,8 @@ views::Label* TrayPopupUtils::CreateDefaultLabel() {
// Frequently the label will paint to a layer that's non-opaque, so subpixel
// rendering won't work unless we explicitly set a background. See
// crbug.com/686363
- label->set_background(
- views::Background::CreateSolidBackground(kBackgroundColor));
- label->SetBackgroundColor(kBackgroundColor);
+ label->set_background(views::Background::CreateThemedSolidBackground(
+ label, ui::NativeTheme::kColorId_BubbleBackground));
return label;
}
@@ -272,8 +272,8 @@ void TrayPopupUtils::ConfigureTrayPopupButton(views::CustomButton* button) {
void TrayPopupUtils::ConfigureAsStickyHeader(views::View* view) {
view->set_id(VIEW_ID_STICKY_HEADER);
- view->set_background(
- views::Background::CreateSolidBackground(kBackgroundColor));
+ view->set_background(views::Background::CreateThemedSolidBackground(
+ view, ui::NativeTheme::kColorId_BubbleBackground));
view->SetBorder(
views::CreateEmptyBorder(gfx::Insets(kMenuSeparatorVerticalPadding, 0)));
view->SetPaintToLayer();

Powered by Google App Engine
This is Rietveld 408576698