Introduce a type of View background that stays in sync with its host

chrome/browser/ui/views/screen_capture_notification_ui_views.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/screen_capture_notification_ui.h"
 
 #include "base/macros.h"
 #include "build/build_config.h"
 #include "chrome/browser/ui/views/chrome_views_export.h"
 #include "chrome/grit/generated_resources.h"
@@ skipping 174 matching lines @@
   // being captured. Make sure it's always the case. Currently we always capture
   // the primary monitor.
   if (ash::Shell::HasInstance())
     params.context = ash::Shell::GetPrimaryRootWindow();
 #endif
 
   widget->set_frame_type(views::Widget::FRAME_TYPE_FORCE_CUSTOM);
   widget->Init(params);
   widget->SetAlwaysOnTop(true);
 
-  set_background(views::Background::CreateSolidBackground(GetNativeTheme()->
-      GetSystemColor(ui::NativeTheme::kColorId_DialogBackground)));
+  set_background(views::Background::CreateThemedSolidBackground(
+      this, ui::NativeTheme::kColorId_DialogBackground));
 
   display::Screen* screen = display::Screen::GetScreen();
   // TODO(sergeyu): Move the notification to the display being captured when
   // per-display screen capture is supported.
   gfx::Rect work_area = screen->GetPrimaryDisplay().work_area();
 
   // Place the bar in the center of the bottom of the display.
   gfx::Size size = widget->non_client_view()->GetPreferredSize();
   gfx::Rect bounds(
       work_area.x() + work_area.width() / 2 - size.width() / 2,
@@ skipping 65 matching lines @@
   client_view_ = new NotificationBarClientView(widget, this);
   return client_view_;
 }
 
 views::NonClientFrameView*
 ScreenCaptureNotificationUIViews::CreateNonClientFrameView(
     views::Widget* widget) {
   views::BubbleFrameView* frame = new views::BubbleFrameView(
       gfx::Insets(), gfx::Insets(kPaddingVertical, kPaddingHorizontal,
                                  kPaddingVertical, kPaddingHorizontal));
   SkColor color = widget->GetNativeTheme()->GetSystemColor(

[msw, 2017/04/19 19:00:54]

What updates this precalculated frame color to match the ThemedSolidBackground
changes that may occur?

[Evan Stade, 2017/04/20 04:44:22]

I'll just leave this file alone. I think the correct fix is that
ScreenCaptureNotificationUIViews ought to be a BubbleDialogDelegate which would
update the bubble border on native theme changes and this function wouldn't
exist. But there's no need to chase down that rabbit hole at this moment.

[msw, 2017/04/20 18:21:46]

Acknowledged.

       ui::NativeTheme::kColorId_DialogBackground);
   frame->SetBubbleBorder(std::unique_ptr<views::BubbleBorder>(
       new views::BubbleBorder(views::BubbleBorder::NONE,
                               views::BubbleBorder::SMALL_SHADOW, color)));
   return frame;
 }
 
 base::string16 ScreenCaptureNotificationUIViews::GetWindowTitle() const {
   return text_;
 }
@@ skipping 31 matching lines @@
   }
 }
 
 }  // namespace
 
 std::unique_ptr<ScreenCaptureNotificationUI>
 ScreenCaptureNotificationUI::Create(const base::string16& text) {
   return std::unique_ptr<ScreenCaptureNotificationUI>(
       new ScreenCaptureNotificationUIViews(text));
 }