third_party/WebKit/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.h - Issue 2816143003: bindings: Place bool flags in a batch in IDL dictionary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.h

Issue 2816143003: bindings: Place bool flags in a batch in IDL dictionary (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl ('K') | « third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.h

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.h b/third_party/WebKit/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.h

index cba1420b038428c355a14548a171e714413b9db4..53e7767cec574a76ace9c44e7cd4c55e4a5df52c 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.h

+++ b/third_party/WebKit/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.h

@@ -49,11 +49,11 @@ class CORE_EXPORT TestDictionaryDerivedImplementedAs : public TestDictionary {

DECLARE_VIRTUAL_TRACE();

private:

+ bool m_hasRequiredLongMember = false;

+ bool m_hasStringOrDoubleSequenceMember = false;

String m_derivedStringMember;

String m_derivedStringMemberWithDefault;

- bool m_hasRequiredLongMember = false;

int32_t m_requiredLongMember;

- bool m_hasStringOrDoubleSequenceMember = false;

HeapVector<StringOrDouble> m_stringOrDoubleSequenceMember;

friend class V8TestDictionaryDerivedImplementedAs;