Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 281613004: Don't let tcmalloc read all kinds of env vars at startup. (Closed)

Created:
6 years, 7 months ago by Nico
Modified:
6 years, 7 months ago
CC:
chromium-reviews, dmikurube+memory_chromium.org
Visibility:
Public.

Description

Don't let tcmalloc read all kinds of env vars at startup. The env vars are still used in profiling=1 builds, by such illustrious figures as the deep memory profiler bot and willchan. Reading from the environment variables uses static initializers, so this change will eliminate those static initializers in profiling=0 builds. As discussed in the chromium-dev thread "Does anyone use tcmalloc's debugging envvars?". BUG=94925 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270850

Patch Set 1 #

Patch Set 2 : profile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M third_party/tcmalloc/chromium/src/base/commandlineflags.h View 1 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
6 years, 7 months ago (2014-05-14 14:45:02 UTC) #1
willchan no longer on Chromium
I updated the CL description to explain that this eliminates static initializers. Feel free to ...
6 years, 7 months ago (2014-05-14 14:59:06 UTC) #2
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 7 months ago (2014-05-15 23:17:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/281613004/20001
6 years, 7 months ago (2014-05-15 23:20:12 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-15 23:24:20 UTC) #5
Message was sent while issue was closed.
Change committed as 270850

Powered by Google App Engine
This is Rietveld 408576698