cc/layers/layer_impl.cc - Issue 2816063003: Replace layer id with Element id for tracking scrollbar animation controllers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/layer_impl.cc

Issue 2816063003: Replace layer id with Element id for tracking scrollbar animation controllers (Closed)

Patch Set: Address reviewer comments & fix ScrollbarVisibilityChangeCausesRedrawAndCommit Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/layers/layer_impl.cc

diff --git a/cc/layers/layer_impl.cc b/cc/layers/layer_impl.cc

index bd7b9fee0a6cb7f3d08943423a4c62aa070b366a..db7d68722458138c03b439cbb1174f0a83ca7454 100644

--- a/cc/layers/layer_impl.cc

+++ b/cc/layers/layer_impl.cc

@@ -344,9 +344,9 @@ void LayerImpl::PushPropertiesTo(LayerImpl* layer) {

layer->layer_property_changed_ = true;

}

+ layer->SetElementId(element_id_);

layer->SetBounds(bounds_);

layer->SetScrollClipLayer(scroll_clip_layer_id_);

- layer->SetElementId(element_id_);

layer->SetMutableProperties(mutable_properties_);

// If the main thread commits multiple times before the impl thread actually