cc/trees/layer_tree_host_unittest.cc - Issue 2816063003: Replace layer id with Element id for tracking scrollbar animation controllers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/layer_tree_host_unittest.cc

Issue 2816063003: Replace layer id with Element id for tracking scrollbar animation controllers (Closed)

Patch Set: Address reviewer comments, pull element_id.h change to another patch Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/trees/layer_tree_host_unittest.cc

diff --git a/cc/trees/layer_tree_host_unittest.cc b/cc/trees/layer_tree_host_unittest.cc

index b54910015e0aa73da6d9904f21e8a42208f1cc84..31f10d92c95ccfaab292969d4d58acd28d83f944 100644

--- a/cc/trees/layer_tree_host_unittest.cc

+++ b/cc/trees/layer_tree_host_unittest.cc

@@ -1750,7 +1750,8 @@ class LayerTreeHostTestNoExtraCommitFromScrollbarInvalidate

bool paint_scrollbar = true;

bool has_thumb = false;

scrollbar_ = FakePaintedScrollbarLayer::Create(paint_scrollbar, has_thumb,

- root_layer_->id());

+ root_layer_->id(),

+ root_layer_->element_id());

scrollbar_->SetPosition(gfx::PointF(0.f, 10.f));

scrollbar_->SetBounds(gfx::Size(10, 10));

@@ -3737,7 +3738,7 @@ class LayerTreeHostTestPropertyChangesDuringUpdateArePushed

bool paint_scrollbar = true;

bool has_thumb = false;

scrollbar_layer_ = FakePaintedScrollbarLayer::Create(

- paint_scrollbar, has_thumb, root_->id());

+ paint_scrollbar, has_thumb, root_->id(), root_->element_id());

root_->AddChild(scrollbar_layer_);