Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4034)

Unified Diff: cc/trees/layer_tree_host_impl.h

Issue 2816063003: Replace layer id with Element id for tracking scrollbar animation controllers (Closed)
Patch Set: Address reviewer comments, pull element_id.h change to another patch Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_host_impl.h
diff --git a/cc/trees/layer_tree_host_impl.h b/cc/trees/layer_tree_host_impl.h
index 26d68d3677e44ec91b6da7923408dfb2aade98c3..b3893b08944c7ddb3daac6bb59adda919d7b731f 100644
--- a/cc/trees/layer_tree_host_impl.h
+++ b/cc/trees/layer_tree_host_impl.h
@@ -321,10 +321,11 @@ class CC_EXPORT LayerTreeHostImpl
size_t SourceAnimationFrameNumberForTesting() const;
- void RegisterScrollbarAnimationController(int scroll_layer_id);
- void UnregisterScrollbarAnimationController(int scroll_layer_id);
- ScrollbarAnimationController* ScrollbarAnimationControllerForId(
- int scroll_layer_id) const;
+ void RegisterScrollbarAnimationController(int scroll_layer_id,
+ ElementId scroll_element_id);
+ void UnregisterScrollbarAnimationController(ElementId scroll_element_id);
+ ScrollbarAnimationController* ScrollbarAnimationControllerForElementId(
+ ElementId scroll_element_id) const;
DrawMode GetDrawMode() const;
@@ -759,8 +760,8 @@ class CC_EXPORT LayerTreeHostImpl
bool did_lock_scrolling_layer_;
bool wheel_scrolling_;
bool scroll_affects_scroll_handler_;
- int scroll_layer_id_mouse_currently_over_;
- int scroll_layer_id_mouse_currently_captured_;
+ ElementId scroll_element_id_mouse_currently_over_;
+ ElementId scroll_element_id_mouse_currently_captured_;
std::vector<std::unique_ptr<SwapPromise>>
swap_promises_for_main_thread_scroll_update_;
@@ -820,9 +821,11 @@ class CC_EXPORT LayerTreeHostImpl
std::unique_ptr<MutatorHost> mutator_host_;
std::set<VideoFrameController*> video_frame_controllers_;
- // Map from scroll layer ID to scrollbar animation controller.
+ // Map from scroll element ID to scrollbar animation controller.
// There is one animation controller per pair of overlay scrollbars.
- std::unordered_map<int, std::unique_ptr<ScrollbarAnimationController>>
+ std::unordered_map<ElementId,
+ std::unique_ptr<ScrollbarAnimationController>,
+ ElementIdHash>
scrollbar_animation_controllers_;
RenderingStatsInstrumentation* rendering_stats_instrumentation_;

Powered by Google App Engine
This is Rietveld 408576698