cc/layers/scrollbar_layer_interface.h - Issue 2816063003: Replace layer id with Element id for tracking scrollbar animation controllers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/scrollbar_layer_interface.h

Issue 2816063003: Replace layer id with Element id for tracking scrollbar animation controllers (Closed)

Patch Set: Address reviewer comments, pull element_id.h change to another patch Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/layers/scrollbar_layer_interface.h

diff --git a/cc/layers/scrollbar_layer_interface.h b/cc/layers/scrollbar_layer_interface.h

index 30c335ba01134ec0d613f0690281cf5723e23e3a..917f709863cc9a9f2d374477b41850115015bf39 100644

--- a/cc/layers/scrollbar_layer_interface.h

+++ b/cc/layers/scrollbar_layer_interface.h

@@ -13,8 +13,9 @@ namespace cc {

class CC_EXPORT ScrollbarLayerInterface {

public:

- virtual int ScrollLayerId() const = 0;

- virtual void SetScrollLayer(int layer_id) = 0;

+ virtual ElementId scroll_element_id() const = 0;

+ // TODO(pdr): Remove layer_id and refactor scrollbars to just use element ids.

+ virtual void SetScrollInfo(int layer_id, ElementId element_id) = 0;

virtual ScrollbarOrientation orientation() const = 0;