Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2346)

Unified Diff: cc/layers/painted_scrollbar_layer.cc

Issue 2816063003: Replace layer id with Element id for tracking scrollbar animation controllers (Closed)
Patch Set: Address reviewer comments, pull element_id.h change to another patch Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layers/painted_scrollbar_layer.cc
diff --git a/cc/layers/painted_scrollbar_layer.cc b/cc/layers/painted_scrollbar_layer.cc
index 98aca6dbe19deec4aa20c91c1fdd543b9845e89c..5ff22021327e1cae4585b5570a6ccfc66d633649 100644
--- a/cc/layers/painted_scrollbar_layer.cc
+++ b/cc/layers/painted_scrollbar_layer.cc
@@ -34,16 +34,19 @@ std::unique_ptr<LayerImpl> PaintedScrollbarLayer::CreateLayerImpl(
scoped_refptr<PaintedScrollbarLayer> PaintedScrollbarLayer::Create(
std::unique_ptr<Scrollbar> scrollbar,
- int scroll_layer_id) {
- return make_scoped_refptr(
- new PaintedScrollbarLayer(std::move(scrollbar), scroll_layer_id));
+ int scroll_layer_id,
+ ElementId scroll_element_id) {
+ return make_scoped_refptr(new PaintedScrollbarLayer(
+ std::move(scrollbar), scroll_layer_id, scroll_element_id));
}
PaintedScrollbarLayer::PaintedScrollbarLayer(
std::unique_ptr<Scrollbar> scrollbar,
- int scroll_layer_id)
+ int scroll_layer_id,
+ ElementId scroll_element_id)
: scrollbar_(std::move(scrollbar)),
scroll_layer_id_(scroll_layer_id),
+ scroll_element_id_(scroll_element_id),
internal_contents_scale_(1.f),
thumb_thickness_(scrollbar_->ThumbThickness()),
thumb_length_(scrollbar_->ThumbLength()),
@@ -57,15 +60,16 @@ PaintedScrollbarLayer::PaintedScrollbarLayer(
PaintedScrollbarLayer::~PaintedScrollbarLayer() {}
-int PaintedScrollbarLayer::ScrollLayerId() const {
- return scroll_layer_id_;
+ElementId PaintedScrollbarLayer::scroll_element_id() const {
+ return scroll_element_id_;
}
-void PaintedScrollbarLayer::SetScrollLayer(int layer_id) {
- if (layer_id == scroll_layer_id_)
+void PaintedScrollbarLayer::SetScrollInfo(int layer_id, ElementId element_id) {
+ if (layer_id == scroll_layer_id_ && element_id == scroll_element_id_)
return;
scroll_layer_id_ = layer_id;
+ scroll_element_id_ = element_id;
SetNeedsFullTreeSync();
}
@@ -87,7 +91,7 @@ void PaintedScrollbarLayer::PushPropertiesTo(LayerImpl* layer) {
PaintedScrollbarLayerImpl* scrollbar_layer =
static_cast<PaintedScrollbarLayerImpl*>(layer);
- scrollbar_layer->SetScrollLayerId(scroll_layer_id_);
+ scrollbar_layer->SetScrollInfo(scroll_layer_id_, scroll_element_id_);
scrollbar_layer->set_internal_contents_scale_and_bounds(
internal_contents_scale_, internal_content_bounds_);

Powered by Google App Engine
This is Rietveld 408576698