cc/input/single_scrollbar_animation_controller_thinning_unittest.cc - Issue 2816063003: Replace layer id with Element id for tracking scrollbar animation controllers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/input/single_scrollbar_animation_controller_thinning_unittest.cc

Issue 2816063003: Replace layer id with Element id for tracking scrollbar animation controllers (Closed)

Patch Set: Address reviewer comments, pull element_id.h change to another patch Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/input/single_scrollbar_animation_controller_thinning_unittest.cc

diff --git a/cc/input/single_scrollbar_animation_controller_thinning_unittest.cc b/cc/input/single_scrollbar_animation_controller_thinning_unittest.cc

index 50659ff44d89ec429021a2a5b1f05eba3d84ce9f..87f9fe43056b8006ddb704355806ac19510a5633 100644

--- a/cc/input/single_scrollbar_animation_controller_thinning_unittest.cc

+++ b/cc/input/single_scrollbar_animation_controller_thinning_unittest.cc

@@ -85,7 +85,8 @@ class SingleScrollbarAnimationControllerThinningTest : public testing::Test {

clip_layer_->test_properties()->AddChild(std::move(scroll_layer));

host_impl_.active_tree()->SetRootLayerForTesting(std::move(clip));

- scrollbar_layer_->SetScrollLayerId(scroll_layer_ptr->id());

+ scrollbar_layer_->SetScrollInfo(scroll_layer_ptr->id(),

+ scroll_layer_ptr->element_id());

scrollbar_layer_->test_properties()->opacity_can_animate = true;

clip_layer_->SetBounds(gfx::Size(100, 100));

scroll_layer_ptr->SetBounds(gfx::Size(200, 200));

« no previous file with comments | « cc/input/scrollbar_animation_controller_unittest.cc ('k') | cc/layers/layer.h » ('j') | cc/layers/scrollbar_layer_impl_base.cc » ('J')