Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: cc/blink/web_scrollbar_layer_impl.cc

Issue 2816063003: Replace layer id with Element id for tracking scrollbar animation controllers (Closed)
Patch Set: Address reviewer comments, pull element_id.h change to another patch Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/blink/web_scrollbar_layer_impl.cc
diff --git a/cc/blink/web_scrollbar_layer_impl.cc b/cc/blink/web_scrollbar_layer_impl.cc
index 2a3f2a12f17b5805f854f09adf4207340bbf8bfb..d96d21bcd9b01ece64b9d2ca31d185c3c23ffc60 100644
--- a/cc/blink/web_scrollbar_layer_impl.cc
+++ b/cc/blink/web_scrollbar_layer_impl.cc
@@ -14,6 +14,7 @@
#include "cc/layers/painted_scrollbar_layer.h"
#include "cc/layers/scrollbar_layer_interface.h"
#include "cc/layers/solid_color_scrollbar_layer.h"
+#include "cc/trees/element_id.h"
using cc::PaintedOverlayScrollbarLayer;
using cc::PaintedScrollbarLayer;
@@ -41,12 +42,14 @@ WebScrollbarLayerImpl::WebScrollbarLayerImpl(
base::MakeUnique<ScrollbarImpl>(std::move(scrollbar),
painter,
std::move(geometry)),
- cc::Layer::INVALID_ID))
+ cc::Layer::INVALID_ID,
+ cc::ElementId()))
: new WebLayerImpl(PaintedScrollbarLayer::Create(
base::MakeUnique<ScrollbarImpl>(std::move(scrollbar),
painter,
std::move(geometry)),
- cc::Layer::INVALID_ID))) {}
+ cc::Layer::INVALID_ID,
+ cc::ElementId()))) {}
WebScrollbarLayerImpl::WebScrollbarLayerImpl(
blink::WebScrollbar::Orientation orientation,
@@ -58,7 +61,8 @@ WebScrollbarLayerImpl::WebScrollbarLayerImpl(
thumb_thickness,
track_start,
is_left_side_vertical_scrollbar,
- cc::Layer::INVALID_ID))) {}
+ cc::Layer::INVALID_ID,
+ cc::ElementId()))) {}
WebScrollbarLayerImpl::~WebScrollbarLayerImpl() {
}
@@ -70,8 +74,9 @@ blink::WebLayer* WebScrollbarLayerImpl::Layer() {
void WebScrollbarLayerImpl::SetScrollLayer(blink::WebLayer* layer) {
cc::Layer* scroll_layer =
layer ? static_cast<WebLayerImpl*>(layer)->layer() : 0;
- layer_->layer()->ToScrollbarLayer()->SetScrollLayer(
- scroll_layer ? scroll_layer->id() : cc::Layer::INVALID_ID);
+ layer_->layer()->ToScrollbarLayer()->SetScrollInfo(
+ scroll_layer ? scroll_layer->id() : cc::Layer::INVALID_ID,
+ scroll_layer ? scroll_layer->element_id() : cc::ElementId());
}
} // namespace cc_blink
« no previous file with comments | « no previous file | cc/input/scrollbar_animation_controller_unittest.cc » ('j') | cc/layers/scrollbar_layer_impl_base.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698