Replace layer id with Element id for tracking scrollbar animation controllers

cc/trees/element_id.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_TREES_ELEMENT_ID_H_
 #define CC_TREES_ELEMENT_ID_H_
 
 #include <stddef.h>
 
 #include <cstdint>
 #include <functional>
 #include <iosfwd>
 #include <memory>
 
 #include "base/hash.h"
 #include "cc/cc_export.h"
 
 namespace base {
 class Value;
 namespace trace_event {
 class TracedValue;
 }  // namespace trace_event
 }  // namespace base
 
 namespace cc {
 

[pdr., 2017/04/18 18:26:49]

I've split out the update to this comment in
https://codereview.chromium.org/2826703003 and will remove it from this review.

-// An "element" is really an animation target. It retains the name element to be
-// symmetric with ElementAnimations and blink::ElementAnimations, but is not
-// in fact tied to the notion of a blink element. It is also not associated with
-// the notion of a Layer. Ultimately, these ids will be used to look up the
-// property tree node associated with the given animation.
+// Element ids are chosen by cc's clients and can be used as a stable identifier
+// across updates.
 //
-// These ids are chosen by cc's clients to permit the destruction and
-// restoration of cc entities (when visuals are hidden and shown) but maintain
-// stable identifiers. There will be a single layer for an ElementId, but
-// not every layer will have an id.
+// Historically, the layer tree stored all compositing data but this has been
+// refactored over time into auxilliary structures such as property trees.
+//
+// For example, in composited scrolling, Layers directly reference scroll tree
+// nodes (Layer::scroll_tree_index) but scroll tree nodes are being refactored
+// to reference stable element ids instead of layers.
+//
+// The animation system (see: ElementAnimations and blink::ElementAnimations) is
+// another auxilliary structure to the layer tree and uses element ids as a
+// stable identifier for animation targets.
 struct CC_EXPORT ElementId {
   ElementId(int primaryId, int secondaryId)
       : primaryId(primaryId), secondaryId(secondaryId) {}
   ElementId() : ElementId(0, 0) {}
 
   bool operator==(const ElementId& o) const;
   bool operator!=(const ElementId& o) const;
   bool operator<(const ElementId& o) const;
 
   // An ElementId's conversion to a boolean value depends only on its primaryId.
@@ skipping 14 matching lines @@
 struct CC_EXPORT ElementIdHash {
   size_t operator()(ElementId key) const;
 };
 
 // Stream operator so ElementId can be used in assertion statements.
 CC_EXPORT std::ostream& operator<<(std::ostream& out, const ElementId& id);
 
 }  // namespace cc
 
 #endif  // CC_TREES_ELEMENT_ID_H_