Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: third_party/WebKit/Source/platform/heap/GCInfo.cpp

Issue 2816033003: Replace ASSERT with DHCECK_op in platform/heap (Closed)
Patch Set: Replace ASSERT with CHECK_op in platform/heap Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/heap/GCInfo.cpp
diff --git a/third_party/WebKit/Source/platform/heap/GCInfo.cpp b/third_party/WebKit/Source/platform/heap/GCInfo.cpp
index 2f4a425ac3bca04a29657ae64303efed0f6f0f20..6b5fda678f29a7e6f791f49466b0c7634fc9434d 100644
--- a/third_party/WebKit/Source/platform/heap/GCInfo.cpp
+++ b/third_party/WebKit/Source/platform/heap/GCInfo.cpp
@@ -18,8 +18,8 @@ GCInfo const** g_gc_info_table = nullptr;
void GCInfoTable::EnsureGCInfoIndex(const GCInfo* gc_info,
size_t* gc_info_index_slot) {
- ASSERT(gc_info);
- ASSERT(gc_info_index_slot);
+ DCHECK(gc_info);
+ DCHECK(gc_info_index_slot);
// Keep a global GCInfoTable lock while allocating a new slot.
DEFINE_THREAD_SAFE_STATIC_LOCAL(Mutex, mutex, new Mutex);
MutexLocker locker(mutex);
@@ -48,11 +48,11 @@ void GCInfoTable::Resize() {
size_t new_size =
gc_info_table_size_ ? 2 * gc_info_table_size_ : kInitialSize;
- ASSERT(new_size < GCInfoTable::kMaxIndex);
+ DCHECK(new_size < GCInfoTable::kMaxIndex);
Hwanseung Lee 2017/04/20 00:30:42 when replaced to DCHECK_LT, it was cause of build
g_gc_info_table =
reinterpret_cast<GCInfo const**>(WTF::Partitions::FastRealloc(
g_gc_info_table, new_size * sizeof(GCInfo), "GCInfo"));
- ASSERT(g_gc_info_table);
+ DCHECK(g_gc_info_table);
memset(reinterpret_cast<uint8_t*>(g_gc_info_table) +
gc_info_table_size_ * sizeof(GCInfo),
kGcInfoZapValue, (new_size - gc_info_table_size_) * sizeof(GCInfo));
@@ -70,8 +70,8 @@ void AssertObjectHasGCInfo(const void* payload, size_t gc_info_index) {
#if !defined(COMPONENT_BUILD)
// On component builds we cannot compare the gcInfos as they are statically
// defined in each of the components and hence will not match.
- ASSERT(HeapObjectHeader::FromPayload(payload)->GcInfoIndex() ==
- gc_info_index);
+ DCHECK_EQ(HeapObjectHeader::FromPayload(payload)->GcInfoIndex(),
+ gc_info_index);
#endif
}
#endif

Powered by Google App Engine
This is Rietveld 408576698