Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1687)

Unified Diff: chrome/browser/password_manager/native_backend_gnome_x_unittest.cc

Issue 2816033002: Fix retrieving federated credentials for the password store for localhost. (Closed)
Patch Set: comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
diff --git a/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc b/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
index ed94a38d901922e25126216485f2e96e6e45e1a1..e6b63a31a4feea52236d4d4f65ed2b799c8d532d 100644
--- a/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
+++ b/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
@@ -888,14 +888,25 @@ TEST_F(NativeBackendGnomeTest, PSLUpdatingStrictAddLogin) {
TEST_F(NativeBackendGnomeTest, FetchFederatedCredentialOnHTTPS) {
other_auth_.signon_realm = "federation://www.example.com/google.com";
+ other_auth_.origin = GURL("https://www.example.com/");
other_auth_.federation_origin = url::Origin(GURL("https://google.com/"));
EXPECT_TRUE(CheckCredentialAvailability(other_auth_,
GURL("https://www.example.com/"),
PasswordForm::SCHEME_HTML, nullptr));
}
+TEST_F(NativeBackendGnomeTest, FetchFederatedCredentialOnLocalhost) {
+ other_auth_.signon_realm = "federation://localhost/google.com";
+ other_auth_.origin = GURL("http://localhost:8080/");
+ other_auth_.federation_origin = url::Origin(GURL("https://google.com/"));
+ EXPECT_TRUE(CheckCredentialAvailability(other_auth_,
+ GURL("http://localhost:8080/"),
+ PasswordForm::SCHEME_HTML, nullptr));
+}
+
TEST_F(NativeBackendGnomeTest, DontFetchFederatedCredentialOnHTTP) {
other_auth_.signon_realm = "federation://www.example.com/google.com";
+ other_auth_.origin = GURL("https://www.example.com/");
other_auth_.federation_origin = url::Origin(GURL("https://google.com/"));
EXPECT_FALSE(CheckCredentialAvailability(other_auth_,
GURL("http://www.example.com/"),
@@ -904,6 +915,7 @@ TEST_F(NativeBackendGnomeTest, DontFetchFederatedCredentialOnHTTP) {
TEST_F(NativeBackendGnomeTest, FetchPSLMatchedFederatedCredentialOnHTTPS) {
other_auth_.signon_realm = "federation://www.sub.example.com/google.com";
+ other_auth_.origin = GURL("https://www.sub.example.com/");
other_auth_.federation_origin = url::Origin(GURL("https://google.com/"));
EXPECT_TRUE(CheckCredentialAvailability(other_auth_,
GURL("https://www.example.com/"),
@@ -912,6 +924,7 @@ TEST_F(NativeBackendGnomeTest, FetchPSLMatchedFederatedCredentialOnHTTPS) {
TEST_F(NativeBackendGnomeTest, DontFetchPSLMatchedFederatedCredentialOnHTTP) {
other_auth_.signon_realm = "federation://www.sub.example.com/google.com";
+ other_auth_.origin = GURL("https://www.sub.example.com/");
other_auth_.federation_origin = url::Origin(GURL("https://google.com/"));
EXPECT_FALSE(CheckCredentialAvailability(other_auth_,
GURL("http://www.example.com/"),

Powered by Google App Engine
This is Rietveld 408576698