Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1187)

Unified Diff: base/trace_event/memory_dump_scheduler.cc

Issue 2815963002: [memory-infra] Trigger first periodic dump after initial period (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/trace_event/memory_dump_scheduler.cc
diff --git a/base/trace_event/memory_dump_scheduler.cc b/base/trace_event/memory_dump_scheduler.cc
index 17921959d38fe7275a37c73341569a8ba1622548..d436afd208ca8a0dc291bca4eae39492553690d2 100644
--- a/base/trace_event/memory_dump_scheduler.cc
+++ b/base/trace_event/memory_dump_scheduler.cc
@@ -72,9 +72,12 @@ void MemoryDumpScheduler::StartInternal(MemoryDumpScheduler::Config config) {
tick_count_ = 0;
light_dump_rate_ = light_dump_period_ms / min_period_ms;
heavy_dump_rate_ = heavy_dump_period_ms / min_period_ms;
- SequencedTaskRunnerHandle::Get()->PostTask(
+ // Keep the legacy behavior of periodic dumps where the first dump is
Primiano Tucci (use gerrit) 2017/04/13 09:48:28 I'd reword this comment to say: (also add a +blank
+ // triggered after |period_ms_|.
+ SequencedTaskRunnerHandle::Get()->PostDelayedTask(
FROM_HERE,
- BindOnce(&MemoryDumpScheduler::Tick, Unretained(this), ++generation_));
+ BindOnce(&MemoryDumpScheduler::Tick, Unretained(this), ++generation_),
+ TimeDelta::FromMilliseconds(period_ms_));
}
void MemoryDumpScheduler::StopInternal() {

Powered by Google App Engine
This is Rietveld 408576698