Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1268)

Unified Diff: chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc

Issue 2815913005: Switch to using scoped_ptr with UserData (Closed)
Patch Set: nico Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
diff --git a/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc b/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
index 9b26180312a80bf44653210c5dd9f2fee490453b..15a843394ca4d4705b022f2a1178db406dc404b0 100644
--- a/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
+++ b/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h"
#include "base/guid.h"
+#include "base/memory/ptr_util.h"
#include "base/run_loop.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/utf_string_conversions.h"
@@ -730,8 +731,8 @@ class RemoveDownloadsTester {
explicit RemoveDownloadsTester(TestingProfile* testing_profile)
: download_manager_(new content::MockDownloadManager()),
chrome_download_manager_delegate_(testing_profile) {
- content::BrowserContext::SetDownloadManagerForTesting(testing_profile,
- download_manager_);
+ content::BrowserContext::SetDownloadManagerForTesting(
+ testing_profile, base::WrapUnique(download_manager_));
EXPECT_EQ(download_manager_,
content::BrowserContext::GetDownloadManager(testing_profile));
@@ -745,7 +746,7 @@ class RemoveDownloadsTester {
content::MockDownloadManager* download_manager() { return download_manager_; }
private:
- content::MockDownloadManager* download_manager_;
+ content::MockDownloadManager* download_manager_; // owned by testing profile
Nico 2017/04/14 18:53:20 ditto
Avi (use Gerrit) 2017/04/14 18:59:38 Done.
ChromeDownloadManagerDelegate chrome_download_manager_delegate_;
DISALLOW_COPY_AND_ASSIGN(RemoveDownloadsTester);

Powered by Google App Engine
This is Rietveld 408576698