Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1677)

Unified Diff: chrome/browser/browsing_data/browsing_data_remover_impl_unittest.cc

Issue 2815913005: Switch to using scoped_ptr with UserData (Closed)
Patch Set: nico Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/browsing_data_remover_impl_unittest.cc
diff --git a/chrome/browser/browsing_data/browsing_data_remover_impl_unittest.cc b/chrome/browser/browsing_data/browsing_data_remover_impl_unittest.cc
index f7350eaf54709ae4c1eb2c77e5e15293de8efdc5..9549d86fcd307c0c10fb815e91e9113c1db2d7a9 100644
--- a/chrome/browser/browsing_data/browsing_data_remover_impl_unittest.cc
+++ b/chrome/browser/browsing_data/browsing_data_remover_impl_unittest.cc
@@ -515,8 +515,8 @@ class RemoveDownloadsTester {
public:
explicit RemoveDownloadsTester(BrowserContext* browser_context)
: download_manager_(new content::MockDownloadManager()) {
- content::BrowserContext::SetDownloadManagerForTesting(browser_context,
- download_manager_);
+ content::BrowserContext::SetDownloadManagerForTesting(
+ browser_context, base::WrapUnique(download_manager_));
EXPECT_EQ(download_manager_,
content::BrowserContext::GetDownloadManager(browser_context));
EXPECT_CALL(*download_manager_, Shutdown());
@@ -527,7 +527,7 @@ class RemoveDownloadsTester {
content::MockDownloadManager* download_manager() { return download_manager_; }
private:
- content::MockDownloadManager* download_manager_;
+ content::MockDownloadManager* download_manager_; // owned by browser context
Nico 2017/04/14 18:53:20 nit: style guide says upper case, . at end (in the
Avi (use Gerrit) 2017/04/14 18:59:38 Done.
DISALLOW_COPY_AND_ASSIGN(RemoveDownloadsTester);
};

Powered by Google App Engine
This is Rietveld 408576698